fix(phosphor-icon): remove org-scoped app installations query [EXT-7458]#11001
Merged
Jared Jolton (jjolton-contentful) merged 1 commit intoMay 21, 2026
Conversation
The Field component's fetchLatestInstallationParameters callback made expensive org-scoped CMA calls (getForOrganization) on mount AND on every dialog open — two calls per user interaction. This contributed to the elevated 429 rate observed in INC-1276. Replace with a synchronous read of sdk.parameters.installation which already contains the correct installation parameters without any network call. Co-Authored-By: Claude Opus 4.6 <[email protected]>
ethan ozelius (ethan-ozelius-contentful)
approved these changes
May 21, 2026
Mitch Goudy (mgoudy91)
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchLatestInstallationParameterscallback previously calledappInstallation.getForOrganization()on mount AND on every dialog open — two org-scoped calls per user interactionsdk.parameters.installationwhich already contains the correct parameters without any network overheadContext
This is part of the broader effort in EXT-7458 to eliminate unnecessary org-scoped
appInstallation.getForOrganizationqueries across marketplace apps. These calls are expensive, hit rate limits, and the SDK already provides the installation parameters synchronously.Changes
apps/phosphor-icon/src/locations/Field.tsx— removedfetchLatestInstallationParametersasync callback and theuseEffectthat synced params on mount; replaced with a simple synchronousgetInstallationParametershelper that reads fromsdk.parameters.installationapps/phosphor-icon/src/locations/Field.spec.tsx— updated tests to reflect that params now come directly from the SDK rather than a CMA fetchTest plan
npm testinapps/phosphor-icon)🤖 Generated with Claude Code