Skip to content

fix(phosphor-icon): remove org-scoped app installations query [EXT-7458]#11001

Merged
Jared Jolton (jjolton-contentful) merged 1 commit into
masterfrom
fix/phosphor-icon-remove-org-installations-query
May 21, 2026
Merged

fix(phosphor-icon): remove org-scoped app installations query [EXT-7458]#11001
Jared Jolton (jjolton-contentful) merged 1 commit into
masterfrom
fix/phosphor-icon-remove-org-installations-query

Conversation

@jjolton-contentful
Copy link
Copy Markdown
Contributor

Summary

  • Removes expensive org-scoped CMA calls from the phosphor-icon Field component that were contributing to elevated 429 rates (INC-1276)
  • The fetchLatestInstallationParameters callback previously called appInstallation.getForOrganization() on mount AND on every dialog open — two org-scoped calls per user interaction
  • Replaced with a synchronous read of sdk.parameters.installation which already contains the correct parameters without any network overhead

Context

This is part of the broader effort in EXT-7458 to eliminate unnecessary org-scoped appInstallation.getForOrganization queries across marketplace apps. These calls are expensive, hit rate limits, and the SDK already provides the installation parameters synchronously.

Changes

  • apps/phosphor-icon/src/locations/Field.tsx — removed fetchLatestInstallationParameters async callback and the useEffect that synced params on mount; replaced with a simple synchronous getInstallationParameters helper that reads from sdk.parameters.installation
  • apps/phosphor-icon/src/locations/Field.spec.tsx — updated tests to reflect that params now come directly from the SDK rather than a CMA fetch

Test plan

  • All 37 existing tests pass (npm test in apps/phosphor-icon)
  • Verify in staging that the icon picker dialog still opens with correct weights/positions/allowed icons
  • Confirm no org-scoped CMA calls in network tab when loading the field or opening the dialog

🤖 Generated with Claude Code

The Field component's fetchLatestInstallationParameters callback made
expensive org-scoped CMA calls (getForOrganization) on mount AND on
every dialog open — two calls per user interaction. This contributed to
the elevated 429 rate observed in INC-1276.

Replace with a synchronous read of sdk.parameters.installation which
already contains the correct installation parameters without any
network call.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
@jjolton-contentful Jared Jolton (jjolton-contentful) merged commit 816327c into master May 21, 2026
14 checks passed
@jjolton-contentful Jared Jolton (jjolton-contentful) deleted the fix/phosphor-icon-remove-org-installations-query branch May 21, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants