Skip to content

fix(drive-integration): handle google-docs-not-found workflow failure []#10998

Open
Mitch Goudy (mgoudy91) wants to merge 2 commits into
masterfrom
fix/google-docs-404-not-found
Open

fix(drive-integration): handle google-docs-not-found workflow failure []#10998
Mitch Goudy (mgoudy91) wants to merge 2 commits into
masterfrom
fix/google-docs-404-not-found

Conversation

@mgoudy91
Copy link
Copy Markdown
Contributor

Summary

  • Adds GOOGLE_DOCS_NOT_FOUND to WorkflowFailureReason enum
  • Wires it through useWorkflowAgent hook and ModalOrchestrator so users see "Document not found" with an actionable message instead of the generic error screen

What changed

  • workflow.ts: new GOOGLE_DOCS_NOT_FOUND enum value
  • messages.ts: new GOOGLE_DOCS_NOT_FOUND error message
  • useWorkflowAgent.ts: recognizes the new failure code and returns the specific message
  • ModalOrchestrator.tsx: handles the new reason in showWorkflowError, renders modal with title "Document not found"

Companion PR

Requires backend change in contentful/agents-api: https://github.com/contentful/agents-api/pull/538

Test plan

  • Trigger a workflow run with an inaccessible or non-existent Google Doc ID — should show "Document not found" modal with actionable message
  • Trigger with an expired token — should still show "Reconnect Drive to continue" modal as before
  • Trigger a generic failure — should still show generic error modal as before

🤖 Generated with Claude Code

@mgoudy91 Mitch Goudy (mgoudy91) changed the title fix(drive-integration): handle google-docs-not-found workflow failure fix(drive-integration): handle google-docs-not-found workflow failure [] May 21, 2026
@mgoudy91 Mitch Goudy (mgoudy91) marked this pull request as ready for review May 21, 2026 16:47
@mgoudy91 Mitch Goudy (mgoudy91) requested review from a team as code owners May 21, 2026 16:47
@mgoudy91 Mitch Goudy (mgoudy91) force-pushed the fix/google-docs-404-not-found branch from 06b0e9f to e583b42 Compare May 21, 2026 17:53
Mitch Goudy (mgoudy91) and others added 2 commits May 21, 2026 11:54
… reason

Adds GOOGLE_DOCS_NOT_FOUND to WorkflowFailureReason and wires it through
the hook and error modal so users see "Document not found" with an
actionable message instead of the generic error screen.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
…v vars

GOOGLE_PICKER_API_KEY and GOOGLE_APP_ID were hardcoded (empty string and
1 respectively), causing the Google Picker to not reliably show files the
user owns — especially newly created docs. Reads from VITE_GOOGLE_PICKER_API_KEY
and VITE_GOOGLE_APP_ID env vars instead, and wires them into CI build steps.

The actual values must be added to CircleCI project environment variables:
- VITE_GOOGLE_PICKER_API_KEY: from GCP > APIs & Services > Credentials > Drive Integration API key
- VITE_GOOGLE_APP_ID: 991777691184 (Contentful Google Docs App project number)

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
@mgoudy91 Mitch Goudy (mgoudy91) force-pushed the fix/google-docs-404-not-found branch from e583b42 to f5a2897 Compare May 21, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants