Move skopeo to go.podman.io#2854
Conversation
baude
force-pushed
the
RUN-4548
branch
2 times, most recently
from
9dcc666 to
fd77a05
Compare
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
ACK to the idea and to these particular changes; but a full text search for github.com/containers/skopeo finds various repo-name-derived paths that would be at least misleading (or perhaps no longer work) after this.
The osx failure is real, probably due to a non-updated github\.com/containers/skopeo regex.
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
Also (frequently assuming a GOPATH layout; we could probably change that but let‘s not do that in this time-sensitive PR):
hack/get_ci_vm.sh.cirrus.ymlinstall.mdMakefileREADME.md
differentiating between GitHub URLs (unchanged) and module name (changed)
|
Ephemeral COPR build failed. @containers/packit-build please check. |
3 similar comments
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
Thanks!
Non-blocking: Also
Line 8 in c0c63bb
There’s some risk that this will break image_test_skopeo_task in container-libs, due to similar GOPATH-like references to the repo. I don’t think we can avoid that risk — switching container-libs to the new module name while the module does not use the new name yet would also not be consistent.
So just a FYI that this might happen today.
|
@baude please rebase. |
With potential repo moves and cirus EOL, we have decided to begin preparing by making changes to the skopeo module name. See containers/go.podman.io#6 for more information. Signed-off-by: Brent Baude <[email protected]>
Found some additional impact locations for the go module change. Signed-off-by: Brent Baude <[email protected]>
|
Given the rebase, I removed the readme you mentioned. |
|
Thanks! |
3 participants
With potential repo moves and cirus EOL, we have decided to begin preparing by making changes to the skopeo module name. See containers/go.podman.io#6 for more information.