Fix test-system and remove stale Makefile target#2731
Merged
Conversation
This was referenced Oct 27, 2025
Member
Author
|
@mtrmac PTAL |
Member
|
LGTM |
mtrmac
reviewed
Oct 30, 2025
`hack/test-system.sh` earlier removed in commit 7e235ea contained a storage.conf setup useful for running system tests in skopeo_cidev container. Getting rid of that also broke `make test-system` because the systemtest: `copy: additional tag` started to break. Running `make test-system-local` isn't ideal for local environments due to creation of system-global containers with predictable names. See: containers#2701 (comment) So, this commit resurrects hack/test-system.sh. Followup commit will modify Makefile targets to use this script again. Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
Member
Author
I think this can go in independently. |
This will ensure both `test-system` and `test-system-local` work. The `test-system` target will use the skopeo binary at `./bin/skopeo`. Setting SKOPEO_BINARY should have no effect on it. The `test-system-local` (and `test-integration-local`) target can use SKOPEO_BINARY at any location. This will be useful in CI where we need to test skopeo installed by the package at /usr/bin. Co-authored-by: Miloslav Trmač <mitr@redhat.com> Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
Old cruft. Isn't even expected to work. Not used anywhere. Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
Member
Author
|
@mtrmac applied your suggestion. Thanks a lot! This is ready to go. |
mtrmac
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Obsoletes #2729 and #2730 . See individual commits.
Doesn't depend on automation_images so this can go in.