AS: fix build with rvps features#553
Merged
Merged
Conversation
Member
Author
|
Let's mark this as draft because there is some overlap to #514 |
Xynnn007
force-pushed
the
fix-rvps-feature
branch
2 times, most recently
from
b1d224c to
2e8cbe9
Compare
Before this commit when we only enable `restful-bin,rvps-grpc` features, the attestation service cannot be built. This patch fixes this issue. Also, this commit deletes the `rvps-builtin` feature as the code of rvps does not bring in any new dependencies. Related configurations are updated to make it more robust, together with the documents. Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
Xynnn007
force-pushed
the
fix-rvps-feature
branch
from
2e8cbe9 to
be83c07
Compare
Member
Author
|
cc @lmilleri @spotlesstofu this might influence operator side i am not sure |
mkulke
approved these changes
Nov 19, 2024
This was referenced Nov 22, 2024
Member
@Xynnn007 thank you for the heads-up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit when we only enable
restful-bin,rvps-grpcfeatures, the attestation service cannot be built.This patch fixes this issue. Also, this commit deletes the
rvps-builtinfeature as the code of rvps does not bring in any new dependencies.Related configurations are updated to make it more robust, together with the documents.