Skip to content

ita: updated trusted_certs_paths property documentation#515

Merged
fitzthum merged 1 commit into
confidential-containers:mainfrom
pawelpros:itadocs
Sep 30, 2024
Merged

ita: updated trusted_certs_paths property documentation#515
fitzthum merged 1 commit into
confidential-containers:mainfrom
pawelpros:itadocs

Conversation

@pawelpros
Copy link
Copy Markdown
Contributor

No description provided.

@pawelpros pawelpros requested a review from a team as a code owner September 27, 2024 10:43
Copy link
Copy Markdown
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment. Also would be good to add a slightly longer commit message even though the PR is very simple.

Comment thread kbs/docs/config.md Outdated
Updated Attestation Token Configuration section in documentation which describes supported trusted_certs_paths values:

- Local PEM file
- Valid URL (local and remote) pointing to JWKSet

Signed-off-by: Pawel Proskurnicki <pawel.proskurnicki@intel.com>
@pawelpros
Copy link
Copy Markdown
Contributor Author

Commit message updated and comment solved

Copy link
Copy Markdown
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fitzthum fitzthum merged commit 7df333d into confidential-containers:main Sep 30, 2024
@mythi
Copy link
Copy Markdown
Contributor

mythi commented Oct 1, 2024

apologies, I did not do any reviews because of #514. It might take some time to get those changes in so getting this merged makes sense.

What's missing is that for "Valid values" we also have Jwk.

@pawelpros pawelpros deleted the itadocs branch October 2, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants