kbs/plugins: add provisioner plugin by MatiasVara · Pull Request #1305 · confidential-containers/trustee

MatiasVara · 2026-04-29T15:30:01Z

Add a provisioner plugin that automates LUKS key generation and resource creation for confidential VMs on behalf of a KubeVirt hook sidecar. When a POST request is received at kbs/v0/provisioner/provision, the plugin:

Generates a random UUID and a LUKS encryption key.
Builds an initdata.toml pointing the guest to the KBS resource path default/{UUID}/root where the key is stored.
Stores the key in the KBS storage backend so the guest can retrieve it after attestation via the existing resource plugin.
Returns a JSON response:

struct ProvisionResponse { uuid: String, oemstring: String, mrconfigid: String, resource_path: String, }

The VMM must inject oemstring and mrconfigid into the VM domain:

oemstring: base64-encoded initdata.toml, passed via SMBIOS OEM string so the guest knows where to fetch its key.
mrconfigid: base64-encoded SHA-384 hash of initdata.toml, injected into the TDX mrConfigId register to bind the VM configuration to hardware attestation.

The plugin also supports DELETE requests at
kbs/v0/provisioner/provision/{uuid} to remove provisioned resources.

Authentication is routed through the KBS admin auth path (validate_auth returns true) instead of requiring a TEE attestation token, since the caller is infrastructure (hook sidecar), not a TEE guest.

Note that I already did a first review using Claude and I left a few TODOs with open questions.

fitzthum

Nice. A couple high-level comments, but this seems generally workable.

fitzthum · 2026-04-29T15:54:27Z

+        // that the `resource` plugin reads from.
+        // TODO: Using overwrite: true could silently replace another VM's key
+        // on UUID collision. Use overwrite: false and handle the conflict error,
+        // or check existence before writing.


Yeah probably should not do this. Instead, you can introduce another endpoint to this plugin for serving resources.

Can you elaborate?

fitzthum · 2026-04-29T15:57:31Z

+        // and scoped roles, e.g.:
+        //   [admin] type = "Simple"
+        //   [[admin.personas]] id = "provisioner" public_key_path = "..."
+        //   [[admin.roles]] id = "provisioner" allowed_endpoints = "^/kbs/v0/provisioner/.*$"


Note that this config is changing a bit, but I think your approach is generally sound. You will have an admin token just for this plugin that will be given to the hook sidecar thing, right?

Xynnn007

Hi @MatiasVara welcome! I left some ideas although it's still draft. I have a question before codes:

KBS now has a mechanism named "external-plugin". See docs. To make it simple, it provides a way for KBS to connect to a gRPC server aside of KBS. In this way, we do not need to make any changes to KBS code. What we need is just changing the KBS config a little. In this way you can have a self-and-easy-maintained plugin server, do you consider to use the mechanism?

MatiasVara · 2026-05-06T09:35:06Z

Hi @MatiasVara welcome! I left some ideas although it's still draft. I have a question before codes:

KBS now has a mechanism named "external-plugin". See docs. To make it simple, it provides a way for KBS to connect to a gRPC server aside of KBS. In this way, we do not need to make any changes to KBS code. What we need is just changing the KBS config a little. In this way you can have a self-and-easy-maintained plugin server, do you consider to use the mechanism?

Oh cool, I did not know that there is that mechanism. I'll investigate it! Do you think it is better that way that having a plugin in-tree?

Xynnn007 · 2026-05-06T11:37:03Z

Do you think it is better that way that having a plugin in-tree?

If it's not a concrete scenario for CoCo, I'd like to say yes. As it's defined by you and can be modified anytime. We will also be benefit of less maintainance effort ; )

MatiasVara · 2026-05-06T12:06:07Z

Do you think it is better that way that having a plugin in-tree?

If it's not a concrete scenario for CoCo, I'd like to say yes. As it's defined by you and can be modified anytime. We will also be benefit of less maintainance effort ; )

I think the plan is to use it in together with kubevirt to provide resources to encrypt the disk for confidential VMs. I completely got you point. It's just that for me it would be easier if it is already in trustee and someone can just enable/disable it but I do not have an strong opinion about it.

fitzthum · 2026-05-06T13:04:06Z

Personally, I think it's fine to have this be an internal plugin. Not all users will use every plugin.

Add a provisioner plugin that automates LUKS key generation and resource creation for confidential VMs on behalf of a KubeVirt hook sidecar. When a POST request is received at `kbs/v0/provisioner/provision`, the plugin: 1. Generates a random UUID and a LUKS encryption key. 2. Builds an initdata.toml pointing the guest to the KBS resource path `default/{UUID}/root` where the key is stored. 3. Stores the key in the KBS storage backend so the guest can retrieve it after attestation via the existing `resource` plugin. 4. Returns a JSON response: struct ProvisionResponse { uuid: String, oemstring: String, mrconfigid: String, resource_path: String, } The VMM must inject `oemstring` and `mrconfigid` into the VM domain: - `oemstring`: base64-encoded initdata.toml, passed via SMBIOS OEM string so the guest knows where to fetch its key. - `mrconfigid`: base64-encoded SHA-384 hash of initdata.toml, injected into the TDX mrConfigId register to bind the VM configuration to hardware attestation. The plugin also supports DELETE requests at `kbs/v0/provisioner/provision/{uuid}` to remove provisioned resources. Authentication is routed through the KBS admin auth path (validate_auth returns true) instead of requiring a TEE attestation token, since the caller is infrastructure (hook sidecar), not a TEE guest. Assisted-by: Claude:claude-4.6-opus-high Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>

Xynnn007

Thanks for adopting previous comments!

If we want to get this into the repo, let me take a closer look at the design.

Based on the concrete logic and dataflow of the plugin, I’m wondering what was the reason for choosing a plugin approach instead of kbs-client+script inside KubeVirt hook sidecar to generate the UUID and set KBS resource?

This question came up when I noticed the storage member inside Provisioner struct. KBS resource plugin is a plugin, and if there is another KeyValueStorageInstance as introduced here with write access, it could potentially race with KBS resource writes.

But yes, if the original idea is that key generation can be triggered by an untrusted entity while keeping the key hidden, then this approach makes sense.

MatiasVara · 2026-05-12T14:33:37Z

Thanks for adopting previous comments!

If we want to get this into the repo, let me take a closer look at the design.

Based on the concrete logic and dataflow of the plugin, I’m wondering what was the reason for choosing a plugin approach instead of kbs-client+script inside KubeVirt hook sidecar to generate the UUID and set KBS resource?

My first PoC was something called Secret-Operator that would do exactly that but I had the problem that I can't trust k8s infrastructure so I decided to deploy it in a different infrastructure that I can trust. Then, I though that, to reduce the number of components, I would prefer to have it in trustee.

This question came up when I noticed the storage member inside Provisioner struct. KBS resource plugin is a plugin, and if there is another KeyValueStorageInstance as introduced here with write access, it could potentially race with KBS resource writes.

yes, It could. What would be the problem of that? I am trying to understand the implications of this design.

But yes, if the original idea is that key generation can be triggered by an untrusted entity while keeping the key hidden, then this approach makes sense.

The whole idea is:

fitzthum · 2026-05-12T15:41:58Z

yes, It could. What would be the problem of that? I am trying to understand the implications of this design.

I don't think you should be accessing the resource storage from the plugin. The plugin should have its own storage namespace. This means adding an endpoint to get the resource via the plugin. This may run into issues with the lack of plugin support in the client, but it's still the way to go I think.

MatiasVara · 2026-05-13T12:51:50Z

yes, It could. What would be the problem of that? I am trying to understand the implications of this design.

I don't think you should be accessing the resource storage from the plugin. The plugin should have its own storage namespace. This means adding an endpoint to get the resource via the plugin. This may run into issues with the lack of plugin support in the client, but it's still the way to go I think.

I can understand that would require changes on the client. Should it also require a PR to somehow give support for the plugin?

fitzthum · 2026-05-13T14:30:05Z

I can understand that would require changes on the client. Should it also require a PR to somehow give support for the plugin?

See confidential-containers/guest-components#1468

MatiasVara mentioned this pull request Apr 29, 2026

Plugin to auto-generate per-VM LUKS secrets at provision time #1277

Open

fitzthum reviewed Apr 29, 2026

View reviewed changes

MatiasVara force-pushed the add-provision-plugin branch 2 times, most recently from c4abca3 to cfde11f Compare May 4, 2026 12:47

Xynnn007 reviewed May 6, 2026

View reviewed changes

MatiasVara force-pushed the add-provision-plugin branch from cfde11f to 5f9d4b3 Compare May 6, 2026 09:50

MatiasVara force-pushed the add-provision-plugin branch from 5f9d4b3 to 9170397 Compare May 6, 2026 16:07

MatiasVara commented May 7, 2026

View reviewed changes

Comment thread kbs/src/plugins/implementations/provisioner.rs

MatiasVara force-pushed the add-provision-plugin branch from 9170397 to fb51ec8 Compare May 7, 2026 14:58

Xynnn007 reviewed May 8, 2026

View reviewed changes

Comment thread kbs/src/plugins/implementations/provisioner.rs

Comment thread kbs/src/plugins/implementations/provisioner.rs

Comment thread kbs/src/plugins/implementations/provisioner.rs

Xynnn007 mentioned this pull request May 14, 2026

docs: update resource URI and add plugin support confidential-containers/guest-components#1468

Open

Conversation

MatiasVara commented Apr 29, 2026

Uh oh!

fitzthum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fitzthum Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

MatiasVara May 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fitzthum Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Xynnn007 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MatiasVara commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Xynnn007 commented May 6, 2026

Uh oh!

MatiasVara commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fitzthum commented May 6, 2026

Uh oh!

Uh oh!

Xynnn007 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MatiasVara commented May 12, 2026

Uh oh!

fitzthum commented May 12, 2026

Uh oh!

MatiasVara commented May 13, 2026

Uh oh!

fitzthum commented May 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MatiasVara commented May 6, 2026 •

edited

Loading

MatiasVara commented May 6, 2026 •

edited

Loading