Add isaaclab#32698
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/isaaclab/recipe.yaml:
For recipes/isaaclab/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/23735950086. Examine the logs at this URL for more detail. |
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
This is necessary to mark them as packages when using find_package in setup.py
|
Hi @diegoferigo, thanks for starting the IsaacLab 3 kit-less recipe and documenting the missing optional dependencies. I continued from your draft by cherry-picking your three commits with authorship preserved, then added a small follow-up cleanup commit on top. The continuation draft is #33296. Current changes there are limited to lint cleanup, switching to I kept IsaacSim out of that draft because the redistributability concern discussed in #32468 still looks unresolved. Happy to defer to you if you prefer to keep this work on #32698 instead. |
|
Thanks for your contributions @jeongseok-meta! I'm still interested in moving this PR forward. It is not stale, I was mainly waiting for upstream updates. One open question for me is conda-forge policy around packaging projects that are still in beta. I initially expected a stable release around May, but based on my latest discussions with upstream developers, that now seems unlikely before late July or August. In the meantime, I've been using a vendored recipe handled with pixi-build in my pixi projects (already including some of the fixes you contributed) so I can stay aligned with the latest upstream revisions. Given the revised timeline, packaging a pre-release may now be worth considering. That said, I would still prefer to wait for the next tagged release, since a few things have changed upstream, especially around subpackages. Adding subpackages to an existing feedstock is somewhat cumbersome because it requires going through conda-forge/admin-requests. The current IsaacLab pinning situation is also not great for conda-forge, and I think that not even my relaxed pinning approach used here is the right long-term solution. Ideally, most dependencies should use That said, I'd be very happy to co-maintain this recipe. We should just align on the remaining steps needed to finalize support. My preference would be to wait at least for the next beta release, but I don't feel strongly about that if conda-forge admins are comfortable starting with pre-release versions. WDYT? |
|
Thanks, that makes sense. I will defer to your original PR and stop pushing my continuation draft so this stays centered on your work. The commits in #33296 are available if any of the lint, test, or dependency cleanup is useful; happy to help cherry-pick pieces or review when you decide whether to wait for the next beta or proceed with the current prerelease. |
|
Thanks, I'll definitely cherry pick your last modifications. Would you still be interested in co-maintain the final feedstock? |
Yes! |
|
Hi @diegoferigo, I did a fresh dependency-availability check while leaving this PR as the source of truth and not pushing to your branch. The active kit-less dependency set looks better now than it did in March. On conda-forge, Still missing or version-limited from the commented optional paths: |
|
Thanks for the overview, @jeongseok-meta. I tried upgrading my prototyping kit-less environment to Newton 1.2 earlier this morning, and so far things are looking quite good. My current plan is to get this PR into good shape by temporarily switching to the For the initial recipe version, I think requiring a manual installation of That would address the most critical issue, although I'm not sure yet what priority upstream is giving to that task. |
|
Thanks, that plan sounds good to me. I agree that |
Co-authored-by: Jeongseok Lee <jeongseok@meta.com>
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/isaaclab/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/25921673773. Examine the logs at this URL for more detail. |
|
I created the following upstream PR with the first batch of updates. I tested these changes locally, and they allow us to remove most of the |
This PR adds a new conda-forge recipe for IsaacLab, a GPU-accelerated open-source framework designed to unify robotics research workflows such as reinforcement learning, imitation learning, and motion planning.
https://github.com/isaac-sim/IsaacLab
The recipe targets the upcoming 3.0 release, which represents a major refactor of the project. Key changes compared to previous versions:
newton#32314Notes for reviewers:
Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).