Restore publish validation now that pub.dev 9576 is fixed - #63
Merged
Conversation
The flag was added because pub.dev returned HTTP 403 for package metadata read with a bearer token, so the OIDC-authenticated resolution that validation performs failed before the upload could start. The workflow comment recorded the exit condition: drop the flag once dart-lang/pub-dev#9576 is fixed. It is fixed. The endpoint now answers 200 with a bearer token, which upstream confirmed on 2026-09-11 and which reproduces today against this package's own advisories endpoint. --force stays: it answers the interactive confirmation a workflow cannot. Only the skipped validation comes back, so the client checks the gating dry run already performs now also run at the upload itself, where the published archive is the one being checked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Drops
--skip-validationfrom the pub.dev publish step.--forcestays.Why now
The flag exists because of dart-lang/pub-dev#9576: pub.dev answered package metadata reads with HTTP 403 when the request carried a bearer token, so the OIDC-authenticated dependency resolution that
dart pub publishperforms during validation failed before the upload could start.This workflow recorded its own exit condition:
That condition is met. Upstream confirmed the fix on 2026-09-11, and it reproduces today:
The same check returns 200 for
mixandwayfinderas well, so this is a server-side fix rather than something specific to one package.What this restores
Validation is the client-side pass that resolves dependencies, checks the pubspec, and inspects the archive before upload. The
testjob gating this one already runsdart pub publish --dry-runat the same commit, so the checks themselves are not new — but the dry run validates a tree, while validation at the upload validates the archive actually being published. Restoring it closes that gap.--forceis unrelated and stays: it answers the interactive confirmation prompt, which a workflow cannot.Checks
test/ci/gate_test.dartassertscontains('dart pub publish --force')and the mandatory dry run; both still hold. Full CI gate passes locally (11/11 ingate_test.dart).Not in this change
The same workaround is live in three other repositories —
conceptadev/wayfinder(three publish workflows),conceptadev/dart-actions(publish.yml) andconceptadev/ack(publish-packages.yml). okf goes first because it carries the explicit removal condition and has no pending release; its next publish is the real-world evidence for the rest.dart-actionsis shared infrastructure whose retirement of this flag is already planned in conceptadev/dart-actions#9, so it should follow that plan rather than be patched ad hoc.