Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ permissions:
env:
SDK_VERSION: "stable"
# The release tool depends on cli_pkg 2.15.2, which uses the Dart 3.11-only
# xml 7 API. The rest of the repository still targets the >=3.4.0 floor.
# xml 7 API. The package floor is now 3.11.0 too, so this no longer isolates a
# higher requirement; it pins an exact SDK where the other jobs track stable.
RELEASE_DART_SDK: "3.11.0"

concurrency:
Expand Down Expand Up @@ -112,8 +113,9 @@ jobs:
run: dart test
shell: bash

# pubspec.yaml promises >=3.9.0. Nothing else in this workflow would notice a
# feature that silently raises the real floor, so keep one job on it.
# pubspec.yaml promises >=3.11.0. Nothing else in this workflow would notice a
# feature that silently raises the real floor, so keep one job on it. It equals
# the stable job only until stable moves past 3.11.
sdk-floor:
name: SDK floor
timeout-minutes: 30
Expand All @@ -125,7 +127,7 @@ jobs:
- name: Prepare environment
uses: ./.github/actions/prepare
with:
sdk-version: "3.9.0"
sdk-version: "3.11.0"

# No format check here: dart format's output is version-dependent, and
# the stable job already enforces the canonical style.
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ topics:
- metadata

environment:
sdk: ">=3.9.0 <4.0.0"
sdk: ">=3.11.0 <4.0.0"

executables:
okf:
Expand Down
7 changes: 4 additions & 3 deletions test/ci/gate_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ void main() {
final releaseEnvironment = releasePubspec['environment'] as YamlMap;
final releaseDependencies = releasePubspec['dependencies'] as YamlMap;

expect((packagePubspec['environment'] as YamlMap)['sdk'], '>=3.9.0 <4.0.0');
final packageSdk = (packagePubspec['environment'] as YamlMap)['sdk'];
expect(packageSdk, '>=3.11.0 <4.0.0');
expect(releasePubspec['name'], 'okf_release');
expect(releasePubspec['publish_to'], 'none');
expect(releaseEnvironment['sdk'], '>=3.11.0 <4.0.0');
Expand Down Expand Up @@ -189,10 +190,10 @@ void main() {
expect(triggers, contains('workflow_call'));
expect(triggers, contains('pull_request'));
expect(jobs, contains('test'));
// pubspec.yaml promises >=3.9.0 and only this job holds it to that.
// pubspec.yaml promises >=3.11.0 and only this job holds it to that.
expect(
(jobs['sdk-floor'] as YamlMap).toString(),
contains('sdk-version: 3.9.0'),
contains('sdk-version: 3.11.0'),
);
expect(
(jobs['test'] as YamlMap).toString(),
Expand Down