feat : Run MetaDrive simulation test in GitHub Actions#37729
Open
mahmudsudo wants to merge 18 commits intocommaai:masterfrom
Open
feat : Run MetaDrive simulation test in GitHub Actions#37729mahmudsudo wants to merge 18 commits intocommaai:masterfrom
mahmudsudo wants to merge 18 commits intocommaai:masterfrom
Conversation
Contributor
Process replay diff reportReplays driving segments through this PR and compares the behavior to master. ✅ 0 changed, 66 passed, 0 errors |
Author
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the requirements for running the MetaDrive simulation test reliably in GitHub Actions, addressing and closes #30693.
Changes include:
whilebusy loop (continue) was consuming a full CPU core. On 2-core GitHub Action runners, this starved openpilot processes, causing the test to lag behind real-time and eventually timeout. Replaced withtime.sleep(0.1)to allow Ratekeeper to maintain proper real-time execution.RECORDenvironment variable to launch_openpilot.sh to unblockloggerdandencoderd. This allows openpilot to captureqlog,rlog, and camera files during the simulation.test_durationconfigurable viaTEST_DURATIONin test_metadrive_bridge.py.simulator_drivingjob in tests.yaml. It now runs for a full 60 seconds (TEST_DURATION=60), passesRECORD=1, and uploads the~/.comma/media/0/realdata/directory as a GitHub Artifact upon completion.Verification
simulator_drivingjob now successfully completes 1 minute of driving without timing out on standard GitHub Action runners.Ratekeeperno longer lags behind real-time.metadrive_logsartifact is correctly generated and contains the expectedqlog,rlog, and.hevccamera files.