cabana: fix crash when zmq address is used#37222
Merged
adeebshihadeh merged 3 commits intocommaai:masterfrom Feb 17, 2026
Merged
cabana: fix crash when zmq address is used#37222adeebshihadeh merged 3 commits intocommaai:masterfrom
adeebshihadeh merged 3 commits intocommaai:masterfrom
Conversation
wpmed92
force-pushed
the
fix-zmq-in-cabana
branch
from
7bbf9f9 to
0752050
Compare
wpmed92
changed the title
wpmed92
changed the title
wpmed92
force-pushed
the
fix-zmq-in-cabana
branch
from
1f4e3bb to
7e957f3
Compare
wpmed92
force-pushed
the
fix-zmq-in-cabana
branch
from
7e957f3 to
86e3766
Compare
wpmed92
force-pushed
the
fix-zmq-in-cabana
branch
from
86e3766 to
2e87d65
Compare
Contributor
|
Thanks! |
FrogAi
pushed a commit
to FrogAi/FrogPilot
that referenced
this pull request
Apr 2, 2026
* Fix zmq support in cabana * Refactor to launch bridge, remove socketadapter * bridge_path should be camel_case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the removal of zmq from msgq, Cabana crashes when a
zmqaddress is provided, as seen in this screenshot:This is because
MSGQSubSocketasserts localhost, so when a non-localhost address in entered in the zmq address textbox, cabana crashes.This PR fixes the crash, and so zmq streaming works again.
Cabana launches a bridge
QProcesswithzmq_addressandcan(whitelisted service) passed in as command line arguments. After the bridge is running, the normalmsgqSubSocketcan be used.After the fix streaming works over zmq: