fix: add issue_message key for first timer pr review action#37155
fix: add issue_message key for first timer pr review action#37155TheSecurityDev wants to merge 4 commits intocommaai:masterfrom
Conversation
|
Huh that didn't work |
There was a problem hiding this comment.
Pull request overview
Fixes the actions/first-interaction@v3 workflow configuration so the action no longer fails due to a missing required input (issue_message) during first-timer PR review runs.
Changes:
- Add the required
issue_messageinput (as an empty string) to theactions/first-interaction@v3step to satisfy input validation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Ohhh so it only applies after it's been merged. It's still running the broken version on this PR. |
|
Looks like empty key has been added already now, let's see if that works instead |
|
Looks like empty works |
Uhh it looks like it doesn't actually 🙃 It only happens on the very first commit when you open the PR, so it's difficult to test. But it just happened again to me on a fresh PR. |
|
@adeebshihadeh I also submitted a PR to |
Similar to #37144, except that it didn't actually fix the error "Input required and not supplied: issue_message", because I think that error started showing now that those other ones were fixed.
It looks like now we always need an "issue_message" key set, even though the trigger is only set for PR reviews, so it's not used. An empty string doesn't seem to work, so I've just added a decent placeholder, even though it's never actually triggered.
Example failure:
https://github.com/commaai/openpilot/pull/37154/checks?sha=9d4f24e201d13a50ad55b6cf3650e475829f270f