Open
Conversation
Contributor
Car behavior reportReplays driving segments through this PR and compares the behavior to master. ✅ No changes detected |
| FINGERPRINTS = { | ||
| CAR.COMMA_BODY: [{ | ||
| 513: 8, 516: 8, 514: 3, 515: 4 | ||
| 513: 8, 516: 8, 514: 3, 515: 4, 517: 8, 518: 6, 519: 6 |
Contributor
There was a problem hiding this comment.
let's split this out into its own PR
Comment on lines
+47
to
+51
| Request( | ||
| [StdQueries.TESTER_PRESENT_REQUEST, StdQueries.APPLICATION_SOFTWARE_FINGERPRINT_REQUEST], | ||
| [StdQueries.TESTER_PRESENT_RESPONSE, StdQueries.APPLICATION_SOFTWARE_FINGERPRINT_RESPONSE], | ||
| bus=0, | ||
| ), |
Contributor
There was a problem hiding this comment.
remove this and just pass the hash with the existing request
Comment on lines
+11
to
+15
| FIRMWARE_VERSION = "v0.3.1" | ||
| BIN_URL = f"https://github.com/commaai/body/releases/download/{FIRMWARE_VERSION}/body.bin.signed" | ||
| BIN_NAME = f"body-v1-{FIRMWARE_VERSION}.bin.signed" | ||
| BODY_DIR = os.path.dirname(os.path.realpath(__file__)) | ||
| _PANDA_BIN_DIR = os.path.join(BODY_DIR, "../../../../panda/board/body/v1") |
Contributor
There was a problem hiding this comment.
let's just move the v1 stuff into panda
| "sector_sizes": [0x4000 for _ in range(4)] + [0x10000] + [0x20000 for _ in range(11)], | ||
| } | ||
|
|
||
| class CanHandle: |
Contributor
There was a problem hiding this comment.
this should live in panda
Comment on lines
+61
to
+71
| def fetch_bin(bin_path, update_url): | ||
| os.makedirs(os.path.dirname(bin_path), exist_ok=True) | ||
| result = subprocess.run( | ||
| ["curl", "-L", "-o", bin_path, "-w", "%{http_code}", "--silent", update_url], | ||
| capture_output=True, text=True | ||
| ) | ||
| status = result.stdout.strip() | ||
| if status == "200": | ||
| print("downloaded latest body firmware binary") | ||
| else: | ||
| raise RuntimeError(f"download failed with HTTP {status}") |
Contributor
There was a problem hiding this comment.
openpilot will pass this in from the panda build obj dir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
body can flash script. runs on initialization of comma body car interface and flashes the body if the firmware signature does not match current version signature