Introduce RW transactions - #139
Open
incipit0 wants to merge 11 commits into
Open
Conversation
Closed
incipit0
force-pushed
the
coln-store/rw-txn
branch
from
September 2, 2026 14:20
f77cb28 to
dcab21d
Compare
Collaborator
|
Understood, thanks very much. One thing about the Automerge itself offers similar ways to update documents, so I am not suggesting this isn't useful. Only that I don't think it will be immediately relevant to the work I am doing here. |
Collaborator
Author
Makes sense, feel free to not use it if you think it's not useful in your case :) |
Rewrite some of the indexing methods. Introduce TableHandle::inner() which allows internal packages to use PackedRowId methods if they wish to.
Now that they are called TxnLiveRowId.
Also did rename SortedTableSnapshot -> SortedTable. snapshot means something special in coln-store, where it is used to rollback operations.
`TableHandle` handles the packing/unpacking to and from WireRowId <-> PackedRowId. Also fold TableMut into TableHandle, not on TestTable.
An empty commit will return early with a all-zero hash and not modify the commit graph. In the future we might want to introduce an option of something like --allow-empty.
Make txn able to read things from table. For now these are mostly dup code from the StoreHandle. I want to redesign the RW interface from coln-store so that might change. For now, we can read stuff inside a transaction.
incipit0
force-pushed
the
coln-store/rw-txn
branch
2 times, most recently
from
September 9, 2026 17:26
445d57e to
4ed1cb8
Compare
Add read/write transactions to coln-store, with typestate. Add convenience methods to do single-shot read/write on the store, internally they will start/finish a transaction for you.
incipit0
force-pushed
the
coln-store/rw-txn
branch
from
September 9, 2026 18:16
4ed1cb8 to
3f7c876
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #138.
@acurrieclark, I added a couple more stuff so now can do R/W on a transaction, and there are also convenience methods like store.add() which will start a transaction for you, add the value, and immediately close it. In general it is not a good thing to do lots of single-shot commit will consume lots of space, but may be nice to have for demo and experimenting.
See the store-access.test for example