Allow reads in txn - #138
Closed
incipit0 wants to merge 2 commits into
Closed
Conversation
An empty commit will return early with a all-zero hash and not modify the commit graph. In the future we might want to introduce an option of something like --allow-empty.
Make txn able to read things from table. For now these are mostly dup code from the StoreHandle. I want to redesign the RW interface from coln-store so that might change. For now, we can read stuff inside a transaction.
|
Thanks so much. I'll rebase and let you know if I have any trouble |
Collaborator
Author
|
Closing in favour of #139 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@acurrieclark I hope this will allow you to read inside txns.... This is a workaround rather than a proper design though, I want to do a more substantial redesign of the read write interface for coln-store, but that might take more time....
I did a bit of renaming of some methods like
begin_transaction, so watch that out as well