Repository navigation
Fix the failing lint, lockfile and acceptance workflow checks - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the CI checks that have been failing on
mainsince #6, so that #8 and later PRs can go green.Code analysis: ran
lint:fixandprettier:fix. The remaining fixes were done by hand:__webpack_nonce__as a global in the patchedinjectStylesIntoStyleTag.jsconsolecalls inmiddleware.jsandrazzle.extend.jswitheslint-disable-next-line no-console, asContentSecurityPolicy.jsxalready doesinjectStylesIntoStyleTag.original.jsto.eslintignoreand.prettierignore. It's the unpatched style-loader copy kept for comparison, so it stays as it is.The rest is formatting only, plus
import/firstmoving therequirebelow theimportinsrc/index.js.Changelog check:
yarn install --immutablefailed becauseyarn.lockstill had the@plone/voltopeer range as^17.0.0, whilepackage.jsonsays^16.0.0 || ^17.0.0. The lockfile is refreshed.Acceptance: GitHub fails the job before it starts because it uses the retired
actions/upload-artifact@v3. It's moved to v4.lint,prettierandstylelintpass locally in theaddon-devcontainer (Volto 17.0.0). The unit test run finds no tests.