Skip to content

Fix the failing lint, lockfile and acceptance workflow checks - #9

Merged
instification merged 1 commit into
mainfrom
fix-ci
Oct 28, 2026
Merged

instification merged 1 commit into
mainfrom
fix-ci

Conversation

@instification

Copy link
Copy Markdown
Member

Fixes the CI checks that have been failing on main since #6, so that #8 and later PRs can go green.

  • Code analysis: ran lint:fix and prettier:fix. The remaining fixes were done by hand:

    • declared __webpack_nonce__ as a global in the patched injectStylesIntoStyleTag.js
    • marked the intended console calls in middleware.js and razzle.extend.js with eslint-disable-next-line no-console, as ContentSecurityPolicy.jsx already does
    • added injectStylesIntoStyleTag.original.js to .eslintignore and .prettierignore. It's the unpatched style-loader copy kept for comparison, so it stays as it is.

    The rest is formatting only, plus import/first moving the require below the import in src/index.js.

  • Changelog check: yarn install --immutable failed because yarn.lock still had the @plone/volto peer range as ^17.0.0, while package.json says ^16.0.0 || ^17.0.0. The lockfile is refreshed.

  • Acceptance: GitHub fails the job before it starts because it uses the retired actions/upload-artifact@v3. It's moved to v4.

lint, prettier and stylelint pass locally in the addon-dev container (Volto 17.0.0). The unit test run finds no tests.

@instification
instification merged commit 589d5c1 into main Oct 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant