Skip to content

Refer to Code of Conduct Version 3.0 hosted at https://pycal.org/code…#1329

Merged
niccokunzmann merged 5 commits intomainfrom
coc-3.0
Apr 20, 2026
Merged

Refer to Code of Conduct Version 3.0 hosted at https://pycal.org/code…#1329
niccokunzmann merged 5 commits intomainfrom
coc-3.0

Conversation

@stevepiercy
Copy link
Copy Markdown
Member

@stevepiercy stevepiercy commented Apr 17, 2026

…-of-conduct/

See pycalendar/pycal.org#26


📚 Documentation preview 📚: https://icalendar--1329.org.readthedocs.build/

@read-the-docs-community
Copy link
Copy Markdown

read-the-docs-community Bot commented Apr 17, 2026

@stevepiercy
Copy link
Copy Markdown
Member Author

@tobixen in case you want to review this.

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 17, 2026

Coverage Report for CI Build 24640696423

Coverage decreased (-0.007%) to 97.749%

Details

  • Coverage decreased (-0.007%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 1 coverage regression across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
src/icalendar/cli.py 1 94.74%

Coverage Stats

Coverage Status
Relevant Lines: 12558
Covered Lines: 12280
Line Coverage: 97.79%
Relevant Branches: 769
Covered Branches: 747
Branch Coverage: 97.14%
Branches in Coverage %: Yes
Coverage Strength: 2.93 hits per line

💛 - Coveralls

niccokunzmann
niccokunzmann previously approved these changes Apr 19, 2026
Copy link
Copy Markdown
Member

@niccokunzmann niccokunzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Do we link to it from the documentation? Then, we could save one redirect.

@niccokunzmann niccokunzmann enabled auto-merge April 19, 2026 21:21
@stevepiercy
Copy link
Copy Markdown
Member Author

@niccokunzmann good catch. It does now in ba7e0fb. One more review, please?

@niccokunzmann niccokunzmann self-requested a review April 20, 2026 08:04
Copy link
Copy Markdown
Member

@niccokunzmann niccokunzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to reduce redirects.

docs/contribute/code-of-conduct.rst also exists and skipping it is fine.

@niccokunzmann niccokunzmann merged commit f77657c into main Apr 20, 2026
21 checks passed
@niccokunzmann niccokunzmann deleted the coc-3.0 branch April 20, 2026 08:07
@stevepiercy
Copy link
Copy Markdown
Member Author

I'd keep the page, so that it appears in the docs navigation. External links with text labels in navigation should be avoided. Icons are OK, like GitHub and PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants