Add docs in __new__ methods to resolve issue #1118#1318
Add docs in __new__ methods to resolve issue #1118#1318Shubham-Developer02 wants to merge 6 commits into
Conversation
Documentation build overview
16 files changed ·
|
|
@Shubham-Developer02 Could you please add a changelog entry? |
|
Thanks @Shubham-Developer02! I will leave the review to @stevepiercy. |
|
|
I didn't know that Additionally, we need to remove duplication of the RFC in our docstrings, and instead document what the class actually does and how to use it, making the docstring more Pythonic. See related issue #1244 for guidance and the discussion. With all that in mind, @Shubham-Developer02 would you please merge the docstrings of just one class and its It can be tricky, so I'd suggest building the docs locally. Thank you! |
|
Hi, we created a new release, please move your edits in CHANGES.rst to the new section. |
Closes issue
Closes #1118
Description
This pull request adds Google-style docstrings to the new methods of immutable value types in icalendar.prop so the API docs explain how instances are constructed and how params is attached:
vBoolean (icalendar.prop.boolean)
vFloat (icalendar.prop.float)
vText (icalendar.prop.text)
vCalAddress (icalendar.prop.cal_address)
vUri (icalendar.prop.uri)
Each docstring summarizes why new is overridden (subclass of int, float, or str), documents Parameters and Returns per the Python docstrings section of the documentation style guide, and includes runnable Examples using .. code-block:: pycon where appropriate.
No behavioral changes to serialization or parsing are intended; this is documentation only.
Link: icalendar documentation style guide — Python docstrings.
Closes issue