Fix docstring style in parser module#1111
Fix docstring style in parser module#1111Himanshu-Vishwakarma-GH wants to merge 4 commits intocollective:mainfrom
Conversation
Pull Request Test Coverage Report for Build 21797239153Details
💛 - Coveralls |
|
@Himanshu-Vishwakarma-GH Thanks for your PR! Can you fill out the description of the PR at the top? Before we merge this, we need to fix the tests... That seems like some work. I also wonder if vale should run on the python files. It could be that it is better to let it run on the output of the built html files - or can it run on docstrings only? |
There was a problem hiding this comment.
Before merging this PR, this file should be removed. It's good to keep it for now, while we troubleshoot the PR and try to understand what's not passing.
|
@Himanshu-Vishwakarma-GH sorry for the multiple posts. Although there are a lot of spelling errors now reported by Vale, many of them are repeated tens or hundreds of times. It shouldn't be too difficult to resolve. See https://icalendar.readthedocs.io/en/latest/contribute/documentation/build-check.html#spelling-grammar-and-style for tips and tricks. Most of the spelling errors appear to be of Python objects. Changing the Please ask if you have any question about how each error should be resolved. These can be tricky, and it's easy to go down the wrong path. |
|
@niccokunzmann I've pushed this forward as far as I care to do at this time. If @Himanshu-Vishwakarma-GH doesn't respond within a reasonable time, then feel free to close this PR as abandoned. I think it would be better to run over the rendered HTML than the Python files. The Vale errors are so numerous on Python files, that I don't think it's worth going down this path. https://github.com/collective/icalendar/actions/runs/21797239154/job/62886736238 |
|
I'll fix that don't worry @stevepiercy |
|
@Himanshu-Vishwakarma-GH Thanks for the help. I think you contributed in a helpful way! We were not sure how we should have approached this issue and it needed someone to step in and go for it so we can evaluate this. You did and it turns out that the approach is not working to spell-check Python files. So you succeeded and we know now that we should look for another way to spell-check the docstrings! There is no need to push this fix forward at the moment from our side. Feel free to experiment of cause! But yeah, thanks for putting the work in so that we have more clarity now! Feel free to close this if you want, I think you did a good job :) |
|
Is there an issue that we can link this in? |
|
I'm still not sure whether rendered HTML or checking Python source is better, as this method does show considerable promise. Let's see if @Himanshu-Vishwakarma-GH can whittle down the errors to something more manageable. Right now it's overwhelming! Also note the |
|
Hi, we created a new release, please move your edits in CHANGES.rst to the new section. |
Closes issue
Replace
ISSUE_NUMBERwith the issue number that your pull request fixes. Then GitHub will link and automatically close the related issue.Description
Write a description of the fixes or improvements.
Checklist
CHANGES.rst.Additional information
Upload screenshots, videos, links to documentation, or any other relevant information.
📚 Documentation preview 📚: https://icalendar--1111.org.readthedocs.build/