Skip to content

Add support for enums and attributes #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Hadatko wants to merge 5 commits into
base: master
Choose a base branch
from
+569 −117
Draft

Add support for enums and attributes #13

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
80606e4
Add support for enums and attributes
Hadatko Oct 21, 2024
c8e32cc
Added missing Enum calls
Hadatko Oct 22, 2024
bd63c99
Fixed typedef usage
Hadatko Oct 22, 2024
f3811d5
Added very basic conditions and fixed blank
Hadatko Oct 22, 2024
0240797
Added enums working in declaration assignment.
Hadatko Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/cfile/writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,8 @@ def _write_function_declaration(self, elem: core.Function) -> None:
self._write("static ")
if isinstance(elem.return_type, core.Type):
self._write_type_declaration(elem.return_type)
if isinstance(elem.return_type, core.TypeDef):

@cogu cogu Oct 22, 2024

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is supposed to be here without having a unit test that proves it. Nevertheless it should say elif here and not if.

@Hadatko Hadatko Oct 22, 2024

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can chage it to elif. But should work similary.
Well i need it here otherwise i cannot generate my code :D

@Hadatko Hadatko Oct 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am doing something like this. Maybe it is not optional. Byt i would like to have function which will return STRING from declaration instead of this hack for cfile.Writer(cfile.StyleOptions()).write_str:

"sizeof({cfile.Writer(cfile.StyleOptions()).write_str(self.cF.sequence().append(self.paramsTypes[param["data"].type]["C"]))})"

@Hadatko Hadatko Oct 23, 2024

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok this change is not necessary as i should use self.cF.func_call("sizeof", [self.paramsTypes[param["data"].type]["C"]]) instead of what i mentioned. I am developing under pressure a bit and lack of documentation is not helping :D

self._write_typedef_usage(elem.return_type)
elif isinstance(elem.return_type, core.Enum):
self._write_enum_usage(elem.return_type)
elif isinstance(elem.return_type, core.Struct):
Expand Down