Use node's SHA256 to hash routines body and add 1 minute cooldown between components check#3328
Open
sebjulliand wants to merge 2 commits into
Open
Use node's SHA256 to hash routines body and add 1 minute cooldown between components check#3328sebjulliand wants to merge 2 commits into
sebjulliand wants to merge 2 commits into
Conversation
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
sebjulliand
added
the
bug
sebjulliand
temporarily deployed
to
testing_environment
GitHub Actions
Inactive
Contributor
|
👋 A new build is available for this PR based on 3e12ae7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
, ### Changes
The Db2 for i
HASH_SHA256built-in function is not available on 7.3.Therefor, the ValidateStatement SQL function from Db2 for i isn't checked on 7.3 but can still be used, unsecurely.
This PR enhance the
getSQLRoutineSignaturemethod to fix that:It also adds a one minute cooldown between two component's state check to reduce the workload for some component that were checked every seconde or (like Db2 syntax checker).
NB: once this is released, Db2 extension will have to be updated and released right after with the new SHA256 hash as the result from the local hash differs from remote's.
How to test this PR
Checklist