feat: expose getSystemVersion() in CodeForIBMi public API#3322
Open
bobcozzi wants to merge 1 commit into
Open
Conversation
Add getSystemVersion() to the CodeForIBMi interface in typings.ts and wire it up in the activate() return object in extension.ts. This allows consumer extensions (e.g. vscode-db2i) to retrieve the IBM i OS version without drilling into the internal IBMi class directly. Usage: const version = api?.getSystemVersion(); // e.g. 7.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exposes
getSystemVersion()as a first-class member of theCodeForIBMipublic API interface, allowing consumer extensions (e.g.vscode-db2i) to retrieve the IBM i OS version without accessing internal implementation details.Changes
src/typings.ts— AddedgetSystemVersion: () => number | undefinedto theCodeForIBMiinterfacesrc/extension.ts— Wired up the implementation in theactivate()return object viainstance.getConnection()?.getSystemVersion()Usage (from a consumer extension)
Returns
undefinedif no connection is active, consistent with other connection-dependent API members.