Use Core SQL signature check#555
Merged
Merged
Conversation
sebjulliand
approved these changes
Jun 29, 2026
sebjulliand
left a comment
sebjulliand
left a comment
Member
There was a problem hiding this comment.
Works fine. Thanks @buzzia2001 !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR uses the updated version of the
getSQLRoutineSignaturemethod to verify the signatures of SQL objects.In the
CheckStatementfile, the signature (the program name, since it is an external procedure) has been updated and the local method has been removed; in theValidateStatementfile, only the signature has been updated (due to the change in algorithm).How to test this PR
To test this PR, you must have the Core version with PR codefori/vscode-ibmi#3328 installed locally.
Connect to the system; there should be no warnings regarding the two SQL objects.
The DB2 version must be released alongside the Core version
Checklist
console.logs I added