Fix: Sidebar group should toggle open/close on click (#5263)#5267
Fix: Sidebar group should toggle open/close on click (#5263)#5267SteKoe merged 3 commits intocodecentric:masterfrom
Conversation
cdprete
left a comment
There was a problem hiding this comment.
To my understanding, too many things have been changed/removed which are unrelated to the bug itself.
Moreover, if I'm right about https://github.com/codecentric/spring-boot-admin/pull/5267/changes#r3095328671, @SteKoe already knows I would open a regression bug if that feature disappears with no real reason ;)
e99ba38 to
f934555
Compare
|
Please rebase your branch correctly as it contains backend changes that are not related to frontend (obviously). |
Yeah, I wanted to suggest the same, but then I saw there were merge commits added by you and @ulischulte, so I was not sure anymore who the culprit was. 😅 |
|
I just rebased and extended the implementation to work as stated in PR description:
|
Without changing the view, right? (aka: no $router.push(...) or so unless an entry in the group is clicked) |
yeah, right! |
Problem
In the instance sidebar, once a group (e.g., "Web") is expanded, clicking it again does not collapse it.
Root Cause
The toggle logic did not correctly reset the open group state when the same group was clicked again.
Solution
Updated the toggle logic to properly toggle between open and closed states.
Notes