Repository navigation
Support @codama/nodes@1.10 optional array attributes - #120
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: bdb7c6f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lorisleiva
force-pushed
the
2.x-support-codama-nodes-1.10
branch
2 times, most recently
from
July 27, 2026 16:38
44580e0 to
b968908
Compare
This backports the optional-array fix (#117) to the 2.x maintenance line. Since `@codama/nodes@1.5.0`, node array attributes are optional (`Array<T> | undefined`) and factories like `structTypeNodeFromInstructionArgumentNodes([])` omit empty arrays, so fresh 2.x installs resolving `@codama/nodes` to 1.10.x crashed during rendering (the Rust counterpart of codama-idl/renderers-js#168). Array reads are guarded with `?? []` throughout the renderer, the new `injectedValueNode` value kind throws an explicit unsupported-node error, the `@codama/*` dependency ranges are raised to `^1.10.0` (`renderers-core` to `^1.3.11`), and the CI workflow now also publishes from the 1.x and 2.x branches.
lorisleiva
force-pushed
the
2.x-support-codama-nodes-1.10
branch
from
July 27, 2026 17:10
b968908 to
bdb7c6f
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports the optional-array fix (#117) to the
2.xmaintenance line.Since
@codama/nodes@1.5.0, node array attributes are optional (Array<T> | undefined) and factories likestructTypeNodeFromInstructionArgumentNodes([])omit empty arrays entirely. As a result, fresh2.xinstalls that resolve@codama/nodes(declared^1.4.4) up to1.10.xcrashed during rendering (the Rust counterpart of the issue reported in codama-idl/renderers-js#168).Array reads are now guarded with
?? []throughout the renderer, and the newinjectedValueNodevalue kind now throws an explicit unsupported-node error rather than being silently mishandled. The@codama/*dependency ranges are raised to^1.10.0(withrenderers-coreto^1.3.11) so the2.xline is genuinely compatible with the current Codama nodes and standard, and the CI workflow now also publishes from the1.xand2.xbranches. The end-to-end fixtures regenerate identically with the updated renderer, so no generated output changes.