Repository navigation
ci: set up Node before the classify job runs the classifier - #2102
Merged
Merged
Conversation
The classify job in ci.yml gates every other job through `needs: classify` and ran `node` with no setup step, so it inherited whatever runtime the runner image shipped. Since 2026-11-02 runs routed to the CNCF self-hosted `gpus` runner group, whose ubuntu-24.04 image ships no `node`, fail with exit 127 while every job that uses setup-node-deps passes on the same machines. Add a bare pinned actions/setup-node step: the classifier imports only `node:` builtins, so it needs a runtime but no `npm ci`. Carry the contract from #2097 (tests/ci-node-runtime-setup.test.mjs): every workflow step that invokes node, npm or npx must be preceded in its job by a step that installs Node, directly or through a local composite action. Its exemption for the classify step is removed, since this change is the fix it pointed at, leaving the allowlist empty. The content-only workflow test now finds the classify step by name instead of by position. Remit: a required CI check failing on main and on every open PR whenever a run lands on a self-hosted runner. Fixes #2096 Refs #2097 Co-authored-by: hivecommons-hive[bot] <hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
✅ Deploy Preview for endusers ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
classifyjob in.github/workflows/ci.ymlgates every other job (needs: classify) and rannodewith no setup step, inheriting whatever runtime the runner image shipped. Since 2026-11-02 15:52Z every run routed to the CNCF self-hostedgpusrunner group fails it withnode: command not found(exit 127) while the four jobs usingsetup-node-depspass on the same machines (runs 41475921935, 41479256008).Remit: a required CI check failing on
mainand on every open PR whenever a run lands on a self-hosted runner.What changed
ci.yml: a bare pinnedactions/setup-nodestep (same SHA assetup-node-deps,node-version: '22') before "Classify changed documents". The classifier imports onlynode:builtins, so nonpm ciis needed and the job stays fast. The literal major is checked for parity with the devcontainer andenginesbytests/dev-environment.test.mjs.tests/ci-node-runtime-setup.test.mjs: the contract from test: require a Node setup step before a job runs node #2097, carried here so it lands with the fix it pointed at. Every workflow step that invokesnode/npm/npxmust be preceded in its job by a Node setup step (directly or via a local composite action). Theclassifyexemption is removed, leavingNODE_SETUP_EXEMPT_STEPSempty; its staleness guard would otherwise fail on this change.tests/content-only-ci-workflow.test.mjs: find the classify step by name rather than index.Verification
node --test tests/ci-node-runtime-setup.test.mjs: 7/7 pass; 6/1 with theci.ymlchange stashednpm run test:unit:coverage:check: pass, gate exit 0check:duplication, Prettier and ESLint on the touched files: passFixes #2096
Refs #2097 (folds its test in; that PR can be closed once this merges)