Repository navigation
Add Bank of Ningbo reference architecture - #2092
Conversation
Adds the reference architecture submitted to the End User TAB in cncf/tab#141: cloud native AI resource management and inference service governance at a regional city commercial bank, using Kubernetes, HAMi and Higress across general-purpose GPU and domestic accelerator clusters, with Spiderpool as a supporting component and Kueue planned. - Hand-authored docs/architectures/bank-of-ningbo/index.md with the architecture diagram colocated under images/ - Mirrored the Higress icon from cncf/artwork - Regenerated data/architectures/catalog.json - Added organization and project terms to the spelling dictionary Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
✅ Deploy Preview for endusers ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Mirrors the header logo published on the bank's official website (https://www.nbcb.com.cn/images/logo.png) so the catalog card shows the organization mark instead of the initial fallback. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
|
Added |
npm run generate:members derives an organization record from each architecture page; the Bank of Ningbo page was added without rerunning it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
|
Two more commits: |
|
Validate repository fails on this head (run 41446815943, The diff adds both Fix: delete the Noted by ci-maintainer agent — the branch is yours, so the one-line removal is left to you rather than pushed. 🐝 Hive Agent: — hive: agent=ci-maintainer backend=copilot model=kimi-k3 copilot=1.0.88 |
There was a problem hiding this comment.
The page, catalog and members records all check out — the one blocker is a redundant cspell entry that fails the required Validate repository check.
CI failure (the only defect I found): .cspell.yml:231 adds higress directly under Higress (.cspell.yml:230). The repository's own guard, tests/cspell-config.test.mjs:66 ("no word entry is made unreachable by a case variant of itself"), fails on exactly this pair — the job log for run 41446815943 shows not ok 1042 with 'higress (already allowed by Higress)'. cspell matches words case-insensitively, so Higress already covers the lowercase occurrences (e.g. the icon path higress-higress-icon-color.svg). Removing the higress line at .cspell.yml:231 should turn the check green; everything else in the run passed.
What I verified from the tree at 2f3ca27:
docs/architectures/bank-of-ningbo/index.mdfront matter matches the regenerateddata/architectures/catalog.jsonrecord (id, title, projects, sourceUrl, published/updated, both assets) and the newdata/members.jsonentry; the China Merchants Bank entry gains itslogo.svgasset consistently in both files.- The diagram reference
./images/architecture.png(index.md:68) and both images exist underdocs/architectures/bank-of-ningbo/images/; alt text is genuinely descriptive. - The three
CNCFProjectCardlogos point at/img/cncf-projects/…, and the new Higress icon is added atstatic/img/cncf-projects/higress-higress-icon-color.svg.
One note for completeness: the PR body's "What changed" section predates the later commits — it doesn't mention data/members.json, the Bank of Ningbo logo.png, or the China Merchants Bank logo.svg (commits b01df9d, 7b38977, 2f3ca27). The commits themselves describe them accurately; a one-line body update would keep the record straight.
With the .cspell.yml:231 line removed this looks correct to me. I have not changed anything on this branch.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88
cspell matches case-insensitively, so Higress already covers the lowercase icon filename; tests/cspell-config.test.mjs rejects the pair. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
2f3ca27 to
7dda935
Compare
|
Thanks, both points addressed:
|
Adds the reference architecture Bank of Ningbo and DaoCloud submitted to the End User TAB in cncf/tab#141 (the full write-up is in this comment), hand-authored the same way as the China Merchants Bank page (
b103650c) rather than through the submission issue template.Remit: end users can now read the Bank of Ningbo architecture (Kubernetes, HAMi and Higress for heterogeneous AI compute and inference-service governance at a city commercial bank) in the reference architecture catalog.
What changed
docs/architectures/bank-of-ningbo/index.md: new page witharchitecture:front matter (sourceUrlpointing at NB Bank: Building a Full-stack Cloud-native AI Service System Based on Kubernetes and HAMi tab#141, industriesFinancial Services, projects Kubernetes, HAMi, Higress) and the architecture diagram colocated underimages/, with descriptive alt text.docs/architectures/bank-of-ningbo/images/logo.png: the bank's published header logo (https://www.nbcb.com.cn/images/logo.png; no vector version is published), used as the catalog card and members avatar.static/img/cncf-projects/higress-higress-icon-color.svg: mirrored byte-for-byte fromcncf/artwork(projects/higress/icon/color).data/architectures/catalog.jsonanddata/members.json: regenerated withnpm run generate:architecturesandnpm run generate:members(12 records; a derived Bank of Ningbo member record)..cspell.yml: Ningbo, Higress, Spiderpool.The China Merchants Bank logo that was briefly on this branch moved to its own PR.
Content notes
cncf/landscape). Spiderpool (sandbox, supporting component) is described in the rationale section; Kueue is described as a Kubernetes SIG subproject and explicitly marked as planned, as the submission states.Validation
npm run check:spelling,markdownlint-cli2on the page,npx prettier --checkon the page, catalog and dictionarynpm run validate:all(12 architecture records, 192 assets, 103 members)node --test tests/architecture*.test.mjs tests/check-data-links.test.mjs tests/content-only-ci*.test.mjs tests/members*.test.mjs tests/cspell-config.test.mjs: passnpm run buildsucceeds;/architectures/bank-of-ningbo/, the diagram at/img/architectures/bank-of-ningbo/architecture.png, the Higress icon and the catalog card all render