Skip to content

Add Bank of Ningbo reference architecture - #2092

Merged
mrbobbytables merged 4 commits into
mainfrom
architectures/bank-of-ningbo
Nov 2, 2026
Merged

mrbobbytables merged 4 commits into
mainfrom
architectures/bank-of-ningbo

Conversation

@mrbobbytables

@mrbobbytables mrbobbytables commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Adds the reference architecture Bank of Ningbo and DaoCloud submitted to the End User TAB in cncf/tab#141 (the full write-up is in this comment), hand-authored the same way as the China Merchants Bank page (b103650c) rather than through the submission issue template.

Remit: end users can now read the Bank of Ningbo architecture (Kubernetes, HAMi and Higress for heterogeneous AI compute and inference-service governance at a city commercial bank) in the reference architecture catalog.

What changed

  • docs/architectures/bank-of-ningbo/index.md: new page with architecture: front matter (sourceUrl pointing at NB Bank: Building a Full-stack Cloud-native AI Service System Based on Kubernetes and HAMi tab#141, industries Financial Services, projects Kubernetes, HAMi, Higress) and the architecture diagram colocated under images/, with descriptive alt text.
  • docs/architectures/bank-of-ningbo/images/logo.png: the bank's published header logo (https://www.nbcb.com.cn/images/logo.png; no vector version is published), used as the catalog card and members avatar.
  • static/img/cncf-projects/higress-higress-icon-color.svg: mirrored byte-for-byte from cncf/artwork (projects/higress/icon/color).
  • data/architectures/catalog.json and data/members.json: regenerated with npm run generate:architectures and npm run generate:members (12 records; a derived Bank of Ningbo member record).
  • .cspell.yml: Ningbo, Higress, Spiderpool.

The China Merchants Bank logo that was briefly on this branch moved to its own PR.

Content notes

  • Prose follows the submitted write-up, lightly edited for the site's voice; no facts, outcomes or metrics were added. The submission reports qualitative preliminary outcomes only, so there is no metrics table.
  • Projects listed as CNCF projects are limited to the three the submission names (Kubernetes, HAMi incubating, Higress sandbox, verified against cncf/landscape). Spiderpool (sandbox, supporting component) is described in the rationale section; Kueue is described as a Kubernetes SIG subproject and explicitly marked as planned, as the submission states.
  • Sections the submission does not cover (what has not worked well, glue) are omitted rather than invented.

Validation

  • npm run check:spelling, markdownlint-cli2 on the page, npx prettier --check on the page, catalog and dictionary
  • npm run validate:all (12 architecture records, 192 assets, 103 members)
  • node --test tests/architecture*.test.mjs tests/check-data-links.test.mjs tests/content-only-ci*.test.mjs tests/members*.test.mjs tests/cspell-config.test.mjs: pass
  • npm run build succeeds; /architectures/bank-of-ningbo/, the diagram at /img/architectures/bank-of-ningbo/architecture.png, the Higress icon and the catalog card all render

Adds the reference architecture submitted to the End User TAB in
cncf/tab#141: cloud native AI resource management and inference service
governance at a regional city commercial bank, using Kubernetes, HAMi and
Higress across general-purpose GPU and domestic accelerator clusters, with
Spiderpool as a supporting component and Kueue planned.

- Hand-authored docs/architectures/bank-of-ningbo/index.md with the
  architecture diagram colocated under images/
- Mirrored the Higress icon from cncf/artwork
- Regenerated data/architectures/catalog.json
- Added organization and project terms to the spelling dictionary

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
@netlify

netlify Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for endusers ready!

Name Link
🔨 Latest commit 7dda935
🔍 Latest deploy log https://app.netlify.com/projects/endusers/deploys/6ae897c77998555ac5bd039b
😎 Deploy Preview https://deploy-preview-2092--endusers.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Mirrors the header logo published on the bank's official website
(https://www.nbcb.com.cn/images/logo.png) so the catalog card shows the
organization mark instead of the initial fallback.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
@mrbobbytables

Copy link
Copy Markdown
Member Author

Added images/logo.png: the header logo published on the bank's official site (https://www.nbcb.com.cn/images/logo.png, 170x49 PNG; no vector version is published). The catalog regenerates with it as the second asset and the catalog card picks it up as the organization avatar. Validators, architecture tests and the build pass.

npm run generate:members derives an organization record from each
architecture page; the Bank of Ningbo page was added without rerunning
it.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
@mrbobbytables

Copy link
Copy Markdown
Member Author

Two more commits: data/members.json regenerated for the derived Bank of Ningbo record (missed in the first commit), and the China Merchants Bank logo added as images/logo.svg, mirrored from the vector CNCF publishes at https://www.cncf.io/wp-content/uploads/2026/07/China_Merchants_Bank_Logo.svg (replaces the unverified raster removed in 76fbd7c). Catalog and members data regenerated; validators, 256 architecture/member tests and the build pass.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Validate repository fails on this head (run 41446815943, tests/cspell-config.test.mjs:66 — "no word entry is made unreachable by a case variant of itself"):

+ 'higress (already allowed by Higress)'

The diff adds both Higress and higress to .cspell.yml words. cspell matches words case-insensitively, so the lowercase form is redundant and the config test rejects it.

Fix: delete the - higress line from .cspell.yml (keep Higress); npm run check:spelling still passes because the lowercase occurrences match case-insensitively.

Noted by ci-maintainer agent — the branch is yours, so the one-line removal is left to you rather than pushed.


🐝 Hive Agent: ci-maintainer | Instance: hosted-available-lke648397-260827-5n31 | SHA: unknown

— hive: agent=ci-maintainer backend=copilot model=kimi-k3 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page, catalog and members records all check out — the one blocker is a redundant cspell entry that fails the required Validate repository check.

CI failure (the only defect I found): .cspell.yml:231 adds higress directly under Higress (.cspell.yml:230). The repository's own guard, tests/cspell-config.test.mjs:66 ("no word entry is made unreachable by a case variant of itself"), fails on exactly this pair — the job log for run 41446815943 shows not ok 1042 with 'higress (already allowed by Higress)'. cspell matches words case-insensitively, so Higress already covers the lowercase occurrences (e.g. the icon path higress-higress-icon-color.svg). Removing the higress line at .cspell.yml:231 should turn the check green; everything else in the run passed.

What I verified from the tree at 2f3ca27:

  • docs/architectures/bank-of-ningbo/index.md front matter matches the regenerated data/architectures/catalog.json record (id, title, projects, sourceUrl, published/updated, both assets) and the new data/members.json entry; the China Merchants Bank entry gains its logo.svg asset consistently in both files.
  • The diagram reference ./images/architecture.png (index.md:68) and both images exist under docs/architectures/bank-of-ningbo/images/; alt text is genuinely descriptive.
  • The three CNCFProjectCard logos point at /img/cncf-projects/…, and the new Higress icon is added at static/img/cncf-projects/higress-higress-icon-color.svg.

One note for completeness: the PR body's "What changed" section predates the later commits — it doesn't mention data/members.json, the Bank of Ningbo logo.png, or the China Merchants Bank logo.svg (commits b01df9d, 7b38977, 2f3ca27). The commits themselves describe them accurately; a one-line body update would keep the record straight.

With the .cspell.yml:231 line removed this looks correct to me. I have not changed anything on this branch.

— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88

cspell matches case-insensitively, so Higress already covers the
lowercase icon filename; tests/cspell-config.test.mjs rejects the pair.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
@mrbobbytables
mrbobbytables force-pushed the architectures/bank-of-ningbo branch from 2f3ca27 to 7dda935 Compare November 2, 2026 14:01
@mrbobbytables

Copy link
Copy Markdown
Member Author

Thanks, both points addressed:

  • 7dda935f removes the redundant lowercase higress entry from .cspell.yml (tests/cspell-config.test.mjs passes locally, npm run check:spelling still clean).
  • The China Merchants Bank logo commit was unrelated to this page, so it has moved to its own PR (Add China Merchants Bank logo to the architecture catalog card #2094) and the branch was force-pushed without it. The PR body now lists images/logo.png and the data/members.json regeneration.

@mrbobbytables
mrbobbytables merged commit 001d74d into main Nov 2, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant