Repository navigation
fix: give the Colopl and ZEISS architectures industry labels - #2017
Conversation
The two imported pages carried slug-style industries (gaming, optics, optical-manufacturing), so the industry filter on /architectures and /members listed them verbatim beside labels such as Financial Services and Public Sector. Title-case the three values in the page front matter and regenerate the catalog and member directory from it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
✅ Deploy Preview for endusers ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Reviewed and verified at head Verified independently:
BLOCKED merge state is the in-progress 🐝 scanner agent review 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=kimi-k3 copilot=1.0.88 |
There was a problem hiding this comment.
Read the tree at merge-base, not just the diff — this checks out.
- On main, the industry vocabulary across
data/architectures/catalog.jsonis Title Case everywhere (Financial Services,Public Sector, …) except exactly the three values this PR fixes:gaming,optics,optical-manufacturing. After the change the catalog has no slug-style industries left. - The filter is safe to re-case:
src/components/ArchitectureFilters/index.js:50-63builds the industry option list from the samearchitecture.industriesarrays it later exact-matches at line 91, and filter state is not persisted in the URL, so no inbound link can carry a stalegamingvalue.src/components/ReferenceArchitectures/index.js:28renders the values verbatim, which is the visible fix. - Leaving the
gamingtag lowercase is correct: tags are normalized withtoLowerCase()atsrc/components/ArchitectureFilters/index.js:19, and the catalog's tags are lowercase throughout. - The regenerated
data/members.jsonmatches whatscripts/generate-members.mjs:112-114would emit: industries are deduped and.sort()ed, and["Optical Manufacturing", "Optics"]is the correct sort order.
Agree that Financial/Financial Services etc. is a separate taxonomy call, and deliberately excluding the SNCF regen drift (owned by #2015) keeps this PR single-purpose. Looks correct to me — leaving the approval signature to a maintainer.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88
Remit: the industry filter on
/architecturesand/members, and the industry tags on the Colopl and ZEISS cards and profiles, show slug-style values (gaming,optics,optical-manufacturing) beside labels such asFinancial ServicesandPublic Sector.What changes
docs/architectures/colopl/index.md: industrygaming->Gaming(the lowercasegamingtag is left alone; tags are lowercase throughout the catalog and are matched case-insensitively).docs/architectures/zeiss/index.md:optics->Optics,optical-manufacturing->Optical Manufacturing.data/architectures/catalog.json,data/members.json: regenerated withnpm run generate:architecturesandnpm run generate:members. The SNCFExternalDNSline the regeneration also produces is deliberately left out; fix: regenerate members.json after the catalog ExternalDNS fix #2015 owns that change.Out of scope, for a maintainer call: the overlapping labels
Financial/Financial Services,Communication/TelecommunicationandTransport/Railacross pages. Merging those is a taxonomy decision rather than a casing fix.Verification
validate:architectures,validate:members, Prettier and cspell cleantests/members-data.test.mjs,tests/architecture-*.test.mjs,tests/validate-architectures.test.mjs: 271 pass