Skip to content

fix: give the Colopl and ZEISS architectures industry labels - #2017

Merged
mrbobbytables merged 1 commit into
cncf:mainfrom
mrbobbytables:fix/architecture-industry-labels
Oct 30, 2026
Merged

mrbobbytables merged 1 commit into
cncf:mainfrom
mrbobbytables:fix/architecture-industry-labels

Conversation

@mrbobbytables

Copy link
Copy Markdown
Member

Remit: the industry filter on /architectures and /members, and the industry tags on the Colopl and ZEISS cards and profiles, show slug-style values (gaming, optics, optical-manufacturing) beside labels such as Financial Services and Public Sector.

What changes

  • docs/architectures/colopl/index.md: industry gaming -> Gaming (the lowercase gaming tag is left alone; tags are lowercase throughout the catalog and are matched case-insensitively).
  • docs/architectures/zeiss/index.md: optics -> Optics, optical-manufacturing -> Optical Manufacturing.
  • data/architectures/catalog.json, data/members.json: regenerated with npm run generate:architectures and npm run generate:members. The SNCF ExternalDNS line the regeneration also produces is deliberately left out; fix: regenerate members.json after the catalog ExternalDNS fix #2015 owns that change.

Out of scope, for a maintainer call: the overlapping labels Financial / Financial Services, Communication / Telecommunication and Transport / Rail across pages. Merging those is a taxonomy decision rather than a casing fix.

Verification

  • validate:architectures, validate:members, Prettier and cspell clean
  • tests/members-data.test.mjs, tests/architecture-*.test.mjs, tests/validate-architectures.test.mjs: 271 pass

The two imported pages carried slug-style industries (gaming, optics,
optical-manufacturing), so the industry filter on /architectures and
/members listed them verbatim beside labels such as Financial Services
and Public Sector.

Title-case the three values in the page front matter and regenerate the
catalog and member directory from it.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
@netlify

netlify Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for endusers ready!

Name Link
🔨 Latest commit fab7565
🔍 Latest deploy log https://app.netlify.com/projects/endusers/deploys/6ae4bc7fb57341a65747661a
😎 Deploy Preview https://deploy-preview-2017--endusers.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Reviewed and verified at head fab75656 — looks correct, approving from the scanner lane.

Verified independently:

  • Only lowercase outliers fixed. On main, the architecture/member industry vocabulary is title-case throughout (Financial Services, Public Sector, …) with exactly three slug-style stragglers: gaming, optics, optical-manufacturing. Case studies already use Gaming. Industry matching in the filters is exact (member.industries.includes(industry)), so casing matters and this change eliminates the slug-style filter options rather than fragmenting them.
  • Regeneration claim holds. Checked out this head, ran generate:architectures ("catalog.json is current") and generate:members, then Prettier: the only difference from the committed data/members.json is the single SNCF External-dns → ExternalDNS line, which the PR body explicitly defers to fix: regenerate members.json after the catalog ExternalDNS fix #2015. Nothing else was silently included or dropped.
  • validate:architectures (10 records), validate:members (102 members) and Prettier all pass on the four touched files.
  • Tags left lowercase as stated; only the two front-matter industries blocks changed.

BLOCKED merge state is the in-progress Validate repository check, not a failure.


🐝 scanner agent review


🐝 Hive Agent: scanner | Instance: hosted-available-lke648397-260827-5n31 | SHA: fab7565

— hive: agent=scanner backend=copilot model=kimi-k3 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the tree at merge-base, not just the diff — this checks out.

  • On main, the industry vocabulary across data/architectures/catalog.json is Title Case everywhere (Financial Services, Public Sector, …) except exactly the three values this PR fixes: gaming, optics, optical-manufacturing. After the change the catalog has no slug-style industries left.
  • The filter is safe to re-case: src/components/ArchitectureFilters/index.js:50-63 builds the industry option list from the same architecture.industries arrays it later exact-matches at line 91, and filter state is not persisted in the URL, so no inbound link can carry a stale gaming value. src/components/ReferenceArchitectures/index.js:28 renders the values verbatim, which is the visible fix.
  • Leaving the gaming tag lowercase is correct: tags are normalized with toLowerCase() at src/components/ArchitectureFilters/index.js:19, and the catalog's tags are lowercase throughout.
  • The regenerated data/members.json matches what scripts/generate-members.mjs:112-114 would emit: industries are deduped and .sort()ed, and ["Optical Manufacturing", "Optics"] is the correct sort order.

Agree that Financial/Financial Services etc. is a separate taxonomy call, and deliberately excluding the SNCF regen drift (owned by #2015) keeps this PR single-purpose. Looks correct to me — leaving the approval signature to a maintainer.

— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88

@mrbobbytables
mrbobbytables added this pull request to the merge queue Oct 30, 2026
Merged via the queue into cncf:main with commit c052be6 Oct 30, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant