[quality] Industry collision guard misses a vertical split by two labels that share no word #2031

Activity

1. hivecommons-hive

   added

   testingApproved by a Hive merger/owner for auto-merge on green CIApproved by a Hive merger/owner for auto-merge on green CI

   agent/qualityApproved by a Hive merger/owner for auto-merge on green CIApproved by a Hive merger/owner for auto-merge on green CI

   stage/040-covered-by-prAn open PR covers this issueAn open PR covers this issue

   on Oct 31, 2026
2. hivecommons-hive commented on Oct 31, 2026

   

   hivecommons-hiveBot

   on Oct 31, 2026 – with hivecommons-hive

   Last edited by hivecommons-hive

   ContributorAuthor

   More actions

   Folded finding. This was filed as a separate issue, but 1 open agent-filed issue (plus 8 closed as completed in the last 14 days) already cite data/architectures/catalog.json, so it was folded into the oldest of them instead of opening another. Treat this issue as the tracker for that component: prefer one structural fix that covers every folded variant over a PR per variant.

   [quality] Architecture tag dropdown is ordered by the build host's locale, not the visitor's served HTML

   Finding

   /architectures serves a static HTML page whose "Add a tag to the search"
   dropdown is ordered by the build host's locale, while every other dropdown on
   the same page is pinned to English. A visitor whose browser collates
   differently from the build host therefore hydrates a different option order
   than the one that was served.

   useArchitectureFilterOptions in src/components/ArchitectureFilters/index.js
   sorts three of its four option lists through
   src/components/shared/compareLabels.js, whose docblock states the rule:

   Locale collation orders letters before case, and pinning the locale keeps
   the order the same on every runtime.

   The tags list is the one that does not. It sorts with a bare
   tagKey(a).localeCompare(tagKey(b)) (index.js:67), which uses the runtime's
   default locale.

   This is observable today

   tagKey() lowercases, so the sorted alphabet is [a-z0-9 ] — but that is not
   enough to make the order locale-independent. Czech collates the digraph ch
   as a single letter that sorts after h, so chaos engineering and ci cd
   swap. The catalog carries both tags.

   Live production HTML (https://endusers.cncf.io/architectures/, fetched
   2026-10-31) orders them build-host-first:

   <option value=cell-based-architecture>cell-based-architecture
   <option value="Chaos engineering">Chaos engineering
   <option value=ci-cd>ci-cd
   <option value="cloud native">cloud native

   The same catalog, through the same exported hook, under a Czech runtime:

   $ LC_ALL=en_US.UTF-8 node probe.mjs
   tags: 5g , adobe , agones , aws , capital-one , cell-based-architecture , Chaos engineering , ci-cd , cloud native , developer-experience
   
   $ LC_ALL=cs_CZ.UTF-8 node probe.mjs
   tags: 5g , adobe , agones , aws , capital-one , cell-based-architecture , ci-cd , cloud native , developer-experience , developer-platforms
   

   (Chaos engineering has moved out of the first ten.) probe.mjs is the
   repository's own test harness driving the real export — no reimplementation:

   import React from 'react';
   import { importSource } from './tests/helpers-jsx.mjs';
   const { useArchitectureFilterOptions } = await importSource(
     'src/components/ArchitectureFilters/index.js',
   );
   const catalog = (await importSource('data/architectures/catalog.json')).default;
   const I = React.__CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE;
   const prev = I.H;
   I.H = { useMemo: (fn) => fn(), useState: (v) => [v, () => {}] };
   console.log('tags:', useArchitectureFilterOptions(catalog).tags.slice(0, 10).join(' , '));
   I.H = prev;

   The industries, projects and organizations lists are byte-identical
   across the two runs, because they go through compareLabels. Only the tag
   list moves. Traditional-Spanish collation (es-u-co-trad) diverges the same
   way.

   Two consequences for that visitor: the served markup and the hydrated markup
   disagree, which React reports as a hydration mismatch and recovers from by
   re-rendering client-side; and the tag dropdown ends up ordered on a different
   rule from the three dropdowns beside it.

   compareAlphabetical in the same file (index.js:32-33), which orders the
   architecture cards under both sort options, is on the same unpinned
   localeCompare. Today's nine organization names do not diverge in any locale
   I tried, so that half is latent — but it is the same call in the same
   function, so it belongs in the same change rather than a second issue later.

   Why no gate caught it

   tests/architecture-filters.test.mjs and
   tests/architecture-filters-ui.test.mjs assert the tag order by rebuilding it
   with the same unpinned localeCompare, so both sides shift together and the
   assertion holds under any locale. Nothing in tests/ pins a collation. This
   is not a re-file of #2013: PR #2016 pinned eight option builders and left this
   one, and the sub-remit note I left on #23 on 2026-10-30 argued it was
   unobservable because "no locale orders that alphabet differently from en".
   The ch digraph is the counter-example; that note was wrong and this issue
   supersedes it.

   Recommendation

   One file, one change. In src/components/ArchitectureFilters/index.js:

   function compareAlphabetical(a, b) {
     return (
       compareLabels(a.organization, b.organization) ||
       compareLabels(a.title, b.title)
     );
   }

   and in useArchitectureFilterOptions:

         tags: Array.from(tags.values()).sort((a, b) =>
           compareLabels(tagKey(a), tagKey(b)),
         ),

   compareLabels is already imported in this file.

   Guard it so it cannot come back: add a fixture pair to
   tests/architecture-filters.test.mjs whose order differs between en and
   cs — Chaos engineering / ci-cd is the pair the real catalog supplies —
   and assert the expected order as a literal rather than recomputing it with
   localeCompare. Running that one test under LC_ALL=cs_CZ.UTF-8 fails before
   the fix and passes after it.

   • compareAlphabetical and the tags comparator both route through compareLabels
   • a unit test pins the Chaos engineering / ci-cd order as a literal and passes under LC_ALL=cs_CZ.UTF-8

   Priority

   • Impact: low — correct content, wrong order plus a recoverable hydration mismatch, for visitors on cs-family and traditional-Spanish collations
   • Effort: low — two comparator call sites in one file, plus one fixture

   The quality lane files no PR here: the fix is production code under src/,
   and a test alone would land red. Same split as #2013 → #2016.

   ---

   🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5n31 | SHA: 53e82aa

   — hive: agent=quality backend=copilot model=claude-opus-5 copilot=1.0.88

   ---

   Folded finding. This was filed as a separate issue, but 1 open agent-filed issue (plus 3 closed as completed in the last 14 days) already cite tests/architecture-catalog-contract.test.mjs, so it was folded into the oldest of them instead of opening another. Treat this issue as the tracker for that component: prefer one structural fix that covers every folded variant over a PR per variant.

   [quality] Project-card gate reads only braced attributes, so hand-written pages escape the two-label check

   Finding

   tests/architecture-catalog-contract.test.mjs holds the gate that keeps one
   CNCF project from being offered twice in the project filter on /architectures
   and /community/members — the defect fixed by hand for Argo and ExternalDNS.
   It learns which project each catalog label names by reading the
   <CNCFProjectCard /> tags on the architecture page.

   Its attribute parser accepts only the braced form:

   new RegExp(`(?:^|\\s)${name}=\\{("(?:[^"\\\\]|\\\\.)*")\\}`)

   That is the form scripts/import-architecture-issue.mjs writes via
   scripts/lib/jsx-attributes.mjs, so every page on main parses. A
   hand-written submission may instead use the plain name="Argo" form, which
   the MDX active-content allowlist accepts (scripts/lib/mdx-active-content.mjs;
   tests/mdx-active-content.test.mjs:21) and the site renders identically. On
   such a page the parser returns null for every attribute, the page
   contributes no labels, and the check passes without covering that
   architecture at all — silently.

   This is live, not hypothetical. The open PR #1976 adds
   docs/architectures/china-merchants-bank/index.md, whose five cards are all
   written in the plain form. Running the gate's own parser over that page
   returns name = null for all five.

   Reproduction, merging #1976 onto main (53e82aa) and planting the defect the
   gate exists to report — a second label for Fluid, as Argo once had three:

   $ git merge origin/main pr-1976
   $ # add "Fluid Dataset" to the page front matter and a plain-form card for it
   $ node scripts/generate-architectures.mjs
   $ node --test tests/architecture-catalog-contract.test.mjs
   ✔ no CNCF project is listed under two labels across the catalog

   The filter would offer both Fluid and Fluid Dataset, each hiding the
   architecture filed under the other, and no gate reports it.

   Recommendation

   Widen the parser in cardAttribute() to read both the braced and the plain
   attribute forms the pages legitimately use, and cover the new form with a
   guard self-check: every page on main uses the braced form, so nothing in the
   catalog would report a parser that reads only that form.

   Test-only; no production code, no data.

   Priority

   • Impact: medium (a filter option that hides architectures reaches production the next time a hand-written submission duplicates a project label)
   • Effort: low (test-only)

   ---

   🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5n31 | SHA: ded6080

   — hive: agent=quality backend=copilot model=claude-opus-5 copilot=1.0.88
3. hivecommons-hive commented on Oct 31, 2026

   

   hivecommons-hiveBot

   on Oct 31, 2026 – with hivecommons-hive

   ContributorAuthor

   More actions

   PR #2032 covers this issue: #2032

   The PR body says this is partial/non-closing work (Refs/Part of or leave-open wording), so Hive will not add a closing keyword. GitHub will not show its issue-list PR icon without a closing keyword; the stage comment is the link.
4. hivecommons-hive commented on Oct 31, 2026

   

   hivecommons-hiveBot

   on Oct 31, 2026 – with hivecommons-hive

   ContributorAuthor

   More actions

   Third finding on this component, filed as its own issue and folded here by the
   relay (which recorded the fold but posted nothing, so this comment is the
   record). Test-only, disjoint from the other two.

   cardAttribute() in tests/architecture-catalog-contract.test.mjs reads
   only the braced attribute form, so a hand-written page escapes the two-label
   check entirely.

   The gate that keeps one CNCF project from being offered twice in the project
   filter on /architectures and /community/members learns which project each
   catalog label names by reading the <CNCFProjectCard /> tags on the page. Its
   parser accepts only name={"Argo"} — the form
   scripts/import-architecture-issue.mjs writes via
   scripts/lib/jsx-attributes.mjs. A hand-written submission may use the plain
   name="Argo" form, which the MDX active-content allowlist accepts
   (scripts/lib/mdx-active-content.mjs) and the site renders identically. On
   such a page every attribute parses as null, the page contributes no labels,
   and the check passes without covering that architecture — with no signal.

   Live, not hypothetical: the open PR #1976 adds
   docs/architectures/china-merchants-bank/index.md with five cards all in the
   plain form; the gate's own parser returns name = null for all five. Merging
   #1976 onto main (53e82aa) and planting the defect the gate exists to report
   — a second label for Fluid, as Argo once had three — leaves
   no CNCF project is listed under two labels across the catalog green, while
   the filter would offer both Fluid and Fluid Dataset, each hiding the
   architecture filed under the other.

   Fix: widen the parser to both forms, with a guard self-check (every page on
   main uses the braced form, so nothing in the catalog would report the gap).
   PR to follow on quality/project-card-attribute-forms.

   ---

   🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5n31 | SHA: ded6080

   — hive: agent=quality backend=copilot model=claude-opus-5 copilot=1.0.88
5. mrbobbytables

   closed this as completedin #2034on Oct 31, 2026
6. hivecommons-hive

   removed

   stage/040-covered-by-prAn open PR covers this issueAn open PR covers this issue

   on Oct 31, 2026
7. mrbobbytables

   added a commit that references this issue on Oct 31, 2026

   fix(architectures): pin the tag and card sort to English collation (c…

   ...

   d760cde