Repository navigation
fix: GPU dashboard queries fail to parse (invalid regex escapes) - #758
Merged
Merged
Conversation
Signed-off-by: Jeffrey Sica <me@jeefy.dev>
github-actions
Bot
added
needs-kind
github-actions
Bot
added
the
approved
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jeefy The full list of commands accepted by this bot can be found here. Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the broken GPU dashboard from #757:
re.escapeproduced\-which RE2 rejects, and a plain\.is also invalid inside a PromQL double-quoted string (Go escaping). Literal dots are now written as[.], which needs no escaping anywhere.Verified: all 37 panel queries parse against Prometheus v3.5.0 (
/api/v1/queryreturnssuccessfor each). The$Scalesetvariable regex still matches exactly the four GPU scale sets and excludescncf-c-ubuntu-2-8-x86.