Remove runtime-tools dependency#317
Open
elezar wants to merge 3 commits into
Open
Conversation
elezar
force-pushed
the
remove-runtime-tools-dependency
branch
3 times, most recently
from
8594a5b to
084a01f
Compare
Contributor
Author
|
@tianon-sso thanks for the work on #316. This here aims to reduce the diff by introducing a @klihub, this should also allow us to more easily switch back to |
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
remove-runtime-tools-dependency
branch
from
084a01f to
3453086
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes runtime-tools by replacing generator calls with an internal OCI spec editor. This allows us to also switch back to using a
Generatorfromruntime-tools/generateif we feel that this makes sense at some stage. Note that a similar interface is used in containerd/containerd#13519.Includes the env cache keying fix from opencontainers/runtime-tools#808 and focused tests.
Assisted by Codex