Skip to content

Use the MSVC pipe function spellings in pio.c #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lenzo-ka wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use the MSVC pipe function spellings in pio.c #506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/util/pio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,16 @@
#include "util/strfuncs.h"
#include "util/ckd_alloc.h"

/* The MSVC/Win32 C runtime exports the pipe functions as _popen/_pclose.
* The POSIX spellings are declared in <stdio.h> (so HAVE_POPEN is defined
* and the code compiles) but are not resolvable when linking a shared
* library, which breaks an MSVC DLL build. Map to the underscore
* spellings on Win32, matching the guard already used for _pclose. */
#if defined(_WIN32) && !defined(__SYMBIAN32__)
#define popen _popen
#define pclose _pclose
#endif

#ifndef EXEEXT
#define EXEEXT ""
#endif
Expand Down Expand Up @@ -186,11 +196,7 @@ fclose_comp(FILE * fp, int32 ispipe)
{
if (ispipe) {
#ifdef HAVE_POPEN
#if defined(_WIN32) && (!defined(__SYMBIAN32__))
_pclose(fp);
#else
pclose(fp);
#endif
#endif
}
else
Expand Down