Skip to content

Remove CloudFront from some class names#1443

Open
phobologic wants to merge 1 commit intomainfrom
alias_over_named_cloudfront_resources
Open

Remove CloudFront from some class names#1443
phobologic wants to merge 1 commit intomainfrom
alias_over_named_cloudfront_resources

Conversation

@phobologic
Copy link
Copy Markdown
Member

It's just ATM, not ATM Machine. :)

It's just ATM, not ATM Machine. :)
Copy link
Copy Markdown
Member

@markpeek markpeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I agree with this change. According to the CF specification, it lists those with "CloudFront". Here's what the auto-generator produces:

class CloudFrontOriginAccessIdentityConfig(AWSProperty):
    props = {
        'Comment': (basestring, True),
    }


class CloudFrontOriginAccessIdentity(AWSObject):
    resource_type = "AWS::CloudFront::CloudFrontOriginAccessIdentity"

    props = {
        'CloudFrontOriginAccessIdentityConfig':
            (CloudFrontOriginAccessIdentityConfig, True),
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants