Skip to content

feat: add allow_dynamic_list_values parameter support to add_metadata… #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
esguerrat merged 2 commits into from
Dec 19, 2025
Merged

feat: add allow_dynamic_list_values parameter support to add_metadata… #724

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e9800f
feat: add allow_dynamic_list_values parameter support to add_metadata…
esguerrat Nov 20, 2025
7527b66
test: add test for updating metadata field with allow_dynamic_list_va…
esguerrat Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,7 @@ exports.update_resources_access_mode_by_ids = function update_resources_access_m
* @return {Object}
*/
exports.add_metadata_field = function add_metadata_field(field, callback, options = {}) {
const params = pickOnlyExistingValues(field, "external_id", "type", "label", "mandatory", "default_value", "validation", "datasource", "restrictions");
const params = pickOnlyExistingValues(field, "external_id", "type", "label", "mandatory", "default_value", "validation", "datasource", "restrictions", "allow_dynamic_list_values");
options.content_type = "json";
return call_api("post", ["metadata_fields"], params, callback, options);
};
Expand Down Expand Up @@ -613,7 +613,7 @@ exports.metadata_field_by_field_id = function metadata_field_by_field_id(externa
* @return {Object}
*/
exports.update_metadata_field = function update_metadata_field(external_id, field, callback, options = {}) {
const params = pickOnlyExistingValues(field, "external_id", "type", "label", "mandatory", "default_value", "validation", "datasource", "restrictions", "default_disabled");
const params = pickOnlyExistingValues(field, "external_id", "type", "label", "mandatory", "default_value", "validation", "datasource", "restrictions", "default_disabled", "allow_dynamic_list_values");
options.content_type = "json";
return call_api("put", ["metadata_fields", external_id], params, callback, options);
};
Expand Down
6 changes: 4 additions & 2 deletions test/integration/api/admin/structured_metadata_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,8 @@ describe("structured metadata api", function () {
},
external_id: EXTERNAL_ID_SET,
label: EXTERNAL_ID_SET,
type: 'set'
type: 'set',
allow_dynamic_list_values: true
};
return api.add_metadata_field(metadata).then((result) => {
Comment thread
esguerrat marked this conversation as resolved.
expect(result).to.beAMetadataField();
Expand All @@ -221,7 +222,8 @@ describe("structured metadata api", function () {
external_id: EXTERNAL_ID_SET,
label: EXTERNAL_ID_SET,
type: 'set',
mandatory: false
mandatory: false,
allow_dynamic_list_values: true
}]).to.beAMetadataField();
});
});
Expand Down
1 change: 1 addition & 0 deletions types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,6 +706,7 @@ declare module 'cloudinary' {

export interface MetadataFieldApiOptions {
external_id?: string;
allow_dynamic_list_values?: boolean;
type?: string;
label?: string;
mandatory?: boolean;
Expand Down
Loading