Fix two flaky test failures caused by test isolation issues#5084
Open
philippthun wants to merge 1 commit intocloudfoundry:mainfrom
Open
Fix two flaky test failures caused by test isolation issues#5084philippthun wants to merge 1 commit intocloudfoundry:mainfrom
philippthun wants to merge 1 commit intocloudfoundry:mainfrom
Conversation
BeforeEnqueueHook: Guard against duplicate plugin registration when
the file is loaded multiple times. Duplicate callbacks caused multiple
PollableJobModel records per enqueue instead of one.
ManifestRouteUpdate: Use .present? instead of truthiness check for
manifest_route[:options]. ManifestRoute.parse always sets options to
{}, which is truthy but semantically empty. This caused spurious
RouteUpdate calls that mutated route columns, breaking Sequel object
equality in subsequent lookups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BeforeEnqueueHook: Guard against duplicate plugin registration when the file is loaded multiple times. Duplicate callbacks caused multiplePollableJobModelrecords per enqueue instead of one.ManifestRouteUpdate: Use.present?instead of truthiness check formanifest_route[:options].ManifestRoute.parsealways sets options to{}, which is truthy but semantically empty. This caused spuriousRouteUpdatecalls that mutated route columns, breaking Sequel object equality in subsequent lookups.I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests