Fix FK violations in unique constraint migrations for security_groups and buildpacks#5069
Merged
johha merged 1 commit intocloudfoundry:mainfrom Apr 28, 2026
Conversation
… and buildpacks Both migrations deleted duplicate rows directly via raw SQL, bypassing Sequel's association hooks. This caused FK constraint violations because referenced child rows were not cleaned up first.
johha
approved these changes
Apr 28, 2026
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Apr 28, 2026
Changes in cloud_controller_ng:
- Fix FK violations in unique constraint migrations for security_groups and buildpacks
PR: cloudfoundry/cloud_controller_ng#5069
Author: serdar özer <serdar.oezer@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both migrations deleted duplicate rows via raw SQL, bypassing Sequel model hooks and causing FK constraint violations on child tables. Fixed by deleting child rows first, security_groups_spaces/staging_security_groups_spaces for security_groups, and buildpack_annotations/buildpack_labels for buildpacks. Tests extended to cover the FK reference scenario in both specs.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests