-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add nub to recognised package managers #14595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+137
−7
Merged
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5bb8b1a
Add nub to recognised package managers
colinhacks bf68c91
Rewrite changeset to describe user-facing impact, not implementation
colinhacks 1e4f3db
Reclassify nub-package-manager changeset as patch
colinhacks 539f578
Support nub in package installation helpers
colinhacks c12edef
Wire nub into detection: wrangler getPackageManager/sniffUserAgent + …
colinhacks fb5ba90
Merge branch 'main' into add-nub-package-manager
NuroDev 50003b0
Reconcile nub package-manager support with merged main and address re…
colinhacks 6984396
Drop stale cli-shared-helpers changeset entry (that file now matches …
colinhacks e6a7442
fix: outdated package manager snapshots
NuroDev 4ec5053
Merge branch 'main' into add-nub-package-manager
NuroDev 0f31b62
Merge branch 'main' into add-nub-package-manager
NuroDev b1741c0
Merge branch 'main' into add-nub-package-manager
NuroDev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| "@cloudflare/workers-utils": minor | ||
| --- | ||
|
|
||
| Add nub to the list of recognised package managers | ||
|
|
||
| Projects using nub can now be automatically detected by their `nub.lock` file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| import { existsSync } from "node:fs"; | ||
| import { join } from "node:path"; | ||
| import { describe, it } from "vitest"; | ||
| import { | ||
| BunPackageManager, | ||
| NpmPackageManager, | ||
| NubPackageManager, | ||
| PnpmPackageManager, | ||
| YarnPackageManager, | ||
| } from "../src/package-manager"; | ||
| import { runInTempDir, seed } from "../src/test-helpers"; | ||
| import type { PackageManager } from "../src/package-manager"; | ||
|
|
||
| const packageManagers: PackageManager[] = [ | ||
| NpmPackageManager, | ||
| PnpmPackageManager, | ||
| YarnPackageManager, | ||
| BunPackageManager, | ||
| NubPackageManager, | ||
| ]; | ||
|
|
||
| describe("package managers", () => { | ||
| it("describes nub", ({ expect }) => { | ||
| expect(NubPackageManager).toEqual({ | ||
| type: "nub", | ||
| npx: "nubx", | ||
| dlx: ["nubx"], | ||
| lockFiles: ["nub.lock"], | ||
| }); | ||
| }); | ||
|
|
||
| describe("lock file detection", () => { | ||
| runInTempDir(); | ||
|
|
||
| // Detection is lock-file-based: a project is managed by the package | ||
| // manager whose lock file is present, matching how consumers resolve it. | ||
| const findByLockFile = (dir: string) => | ||
| packageManagers.find((pm) => | ||
| pm.lockFiles.some((lockFile) => existsSync(join(dir, lockFile))) | ||
| ); | ||
|
|
||
| it("detects nub from nub.lock", async ({ expect }) => { | ||
| await seed({ "nub.lock": "" }); | ||
| expect(findByLockFile(process.cwd())).toBe(NubPackageManager); | ||
| }); | ||
| }); | ||
|
NuroDev marked this conversation as resolved.
|
||
| }); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.