Repository navigation
Rotate edge addresses after control stream failures - #1785
Open
akasakariko wants to merge 1 commit into
Open
akasakariko wants to merge 1 commit into
akasakariko wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The address fallback policy does not recognize ordinary control stream failures, so retries keep the address already assigned to that connection
Successful registration also resets the retry backoff, allowing repeated control stream failures to keep a connector pinned indefinitely
Rotate on the control stream failure itself rather than introducing another counter that successful registration could reset
Reproduction
Run the focused regression from the supervisor directory
Verification
make test lintpasses on macOS ARM64 with the repository pinned Go toolchain and race detection enabledScope
This change addresses automatic edge recovery only, HA connection metrics and readiness semantics remain unchanged
Fixes #1771