Repository navigation
Publish to npm with trusted publishing - #240
Merged
Merged
Conversation
The publish workflows read a NODE_AUTH_TOKEN secret that does not exist, so the first release failed with 'need auth'. Before the monorepo, packages were published with npm trusted publishing (OIDC). Request an id-token, install npm 11.5.1 or later, and document the trusted publisher settings that npmjs.com needs for each package after the rename to cloudflare/browser-run.
|
npm i https://pkg.pr.new/cloudflare/browser-run/@cloudflare/playwright-mcp@d29707f7ee064864289ebdbdc066055cc810f8c6Published by this workflow run. New pushes and reruns update this comment. |
|
npm i https://pkg.pr.new/cloudflare/browser-run/@cloudflare/playwright@d29707f7ee064864289ebdbdc066055cc810f8c6Published by this workflow run. New pushes and reruns update this comment. |
|
npm i https://pkg.pr.new/cloudflare/browser-run/@cloudflare/puppeteer@d29707f7ee064864289ebdbdc066055cc810f8c6Published by this workflow run. New pushes and reruns update this comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The first release from the monorepo,
cloudflare-puppeteer-v1.5.0-rc.0, failed atnpm publishwithnpm error need auth(run 38365750713). The publish workflows read aNODE_AUTH_TOKENsecret that this repository does not have. Nothing was published.Before the monorepo,
@cloudflare/puppeteer(1.4.0) and@cloudflare/playwright(1.3.6) were published with npm trusted publishing (OIDC), not a token.Change
id-tokenand install npm 11.5.1 or later, which trusted publishing needs.NODE_AUTH_TOKEN.RELEASING.mdlists the trusted publisher settings that npmjs.com needs for each package.Required before the next release
A package owner on npmjs.com must set a GitHub Actions trusted publisher for each package. Leave the environment empty.
@cloudflare/puppeteercloudflare/browser-runcf_puppeteer_publish.yml@cloudflare/playwrightcloudflare/browser-runcf_playwright_publish.yml@cloudflare/playwright-mcpcloudflare/browser-runcf_playwright_mcp_publish.ymlThe Puppeteer and Playwright packages have trusted publishers for the old repositories and workflow files.
@cloudflare/playwright-mcp0.0.5 was published manually and has no trusted publisher yet.After merge
main. The publish workflows require them for the release commit.cloudflare-puppeteer-v1.5.0-rc.0. A rerun of the failed run uses the old workflow.maincommit. Version1.5.0-rc.0is still unpublished.