Skip to content

ci: add npm publish workflow for wasm packages - #274

Merged
lukevalenta merged 1 commit into
cloudflare:mainfrom
by-cf:byang/publish-wasm-npm
Aug 17, 2026
Merged

ci: add npm publish workflow for wasm packages#274
lukevalenta merged 1 commit into
cloudflare:mainfrom
by-cf:byang/publish-wasm-npm

Conversation

@by-cf

@by-cf by-cf commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@lukevalenta

Copy link
Copy Markdown
Contributor

/bigbonk review

@ask-bonk

ask-bonk Bot commented Aug 17, 2026

Copy link
Copy Markdown

github run

@ask-bonk

ask-bonk Bot commented Aug 17, 2026

Copy link
Copy Markdown

@lukevalenta Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@lukevalenta

Copy link
Copy Markdown
Contributor

/bonk review

Comment thread .github/workflows/publish-npm.yml
Comment thread .github/workflows/publish-npm.yml Outdated
Comment thread .github/workflows/publish-npm.yml
Comment thread .github/workflows/publish-npm.yml Outdated
Comment thread .github/workflows/publish-npm.yml Outdated
@ask-bonk

ask-bonk Bot commented Aug 17, 2026

Copy link
Copy Markdown

Submitted a review with 5 inline comments. Here's a summary of the additional actionable finding not covered inline:

  • Unused id-token: write permission: The workflow requests id-token: write, which is typically needed for npm provenance (OIDC). If provenance was intended, add --provenance to the npm publish commands; otherwise, remove the unnecessary permission.

github run

@by-cf
by-cf force-pushed the byang/publish-wasm-npm branch from 1106737 to 3d00f13 Compare August 17, 2026 18:10
@by-cf
by-cf force-pushed the byang/publish-wasm-npm branch from 3d00f13 to dc188a2 Compare August 17, 2026 18:17
@by-cf

by-cf commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

/bonk review

1 similar comment
@lukevalenta

Copy link
Copy Markdown
Contributor

/bonk review

@lukevalenta

Copy link
Copy Markdown
Contributor

@by-cf bonk review is gated to CODEOWNERS, but if you want to submit a PR to add yourself I'm happy to approve!

@ask-bonk

ask-bonk Bot commented Aug 17, 2026

Copy link
Copy Markdown

LGTM!

github run

@lukevalenta
lukevalenta merged commit 5dff53d into cloudflare:main Aug 17, 2026
7 checks passed
@by-cf

by-cf commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

@by-cf bonk review is gated to CODEOWNERS, but if you want to submit a PR to add yourself I'm happy to approve!

#275 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants