Skip to content
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
897099c
chore(repo): Upgrade to TypeScript 6.0
dstaley Mar 27, 2026
8301649
fix(expo-passkeys): Use new lib DOM types (#8178)
dstaley Mar 27, 2026
c980c0e
fix(backend): TypeScript 6.0 compatibility (#8179)
dstaley Mar 27, 2026
de7c97e
chore(localizations): Migrate to tsdown (#8180)
dstaley Mar 27, 2026
c62e6ab
chore(testing): TypeScript 6.0 compatibility (#8182)
dstaley Mar 27, 2026
843a673
chore(hono): TypeScript 6.0 compatibility (#8183)
dstaley Mar 27, 2026
9250276
chore(agent-toolkit): TypeScript 6.0 compatibility (#8184)
dstaley Mar 27, 2026
c2f60f3
chore(fastify): TypeScript 6.0 compatibility (#8185)
dstaley Mar 27, 2026
d8c8801
chore(vue): Migrate to tsdown (#8188)
wobsoriano Mar 27, 2026
6a300ef
chore(ui): TypeScript 6.0 compatibility (#8190)
dstaley Mar 27, 2026
c54142a
chore(express): TypeScript 6.0 compatibility (#8187)
dstaley Mar 27, 2026
75100e2
chore(astro): TypeScript 6.0 compatibility (#8191)
dstaley Mar 27, 2026
81001cb
chore(nuxt): Support TS6 and migrate to tsdown (#8192)
wobsoriano Mar 27, 2026
75b8816
chore(react): TypeScript 6.0 compatibility (#8194)
dstaley Mar 28, 2026
ef2d238
chore(clerk-js): TypeScript 6.0 compatibility (#8193)
dstaley Mar 28, 2026
5dbf5bd
Merge branch 'main' into ds.chore/ts-6.0
dstaley Mar 30, 2026
c1f0691
chore(nextjs): TypeScript 6.0 compatibility (#8201)
dstaley Mar 30, 2026
e57e2c0
chore(chrome-extension): TypeScript 6.0 compatibility (#8202)
dstaley Mar 30, 2026
4d2aaf6
chore(tanstack-react-start): TypeScript 6.0 compatibility (#8204)
dstaley Mar 30, 2026
91e83cb
chore(react-router): TypeScript 6.0 compatibility (#8206)
dstaley Mar 30, 2026
b9c484f
chore(expo): TypeScript 6.0 compatibility (#8200)
dstaley Mar 31, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 0 additions & 36 deletions packages/expo-passkeys/src/ClerkExpoPasskeys.types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,50 +43,14 @@ export type SerializedPublicKeyCredentialRequestOptions = Omit<
challenge: string;
};

// The return type from the "get" native module.
export interface AuthenticationResponseJSON {
id: string;
rawId: string;
response: AuthenticatorAssertionResponseJSON;
authenticatorAttachment?: AuthenticatorAttachment;
clientExtensionResults: AuthenticationExtensionsClientOutputs;
type: PublicKeyCredentialType;
}

// The serialized response of the native module "create" response to be send back to clerk
export type PublicKeyCredentialWithAuthenticatorAttestationResponse =
ClerkPublicKeyCredentialWithAuthenticatorAttestationResponse & {
toJSON: () => any;
};

interface AuthenticatorAssertionResponseJSON {
clientDataJSON: string;
authenticatorData: string;
signature: string;
userHandle?: string;
}

// The serialized response of the native module "get" response to be send back to clerk
export type PublicKeyCredentialWithAuthenticatorAssertionResponse =
ClerkPublicKeyCredentialWithAuthenticatorAssertionResponse & {
toJSON: () => any;
};

interface AuthenticatorAttestationResponseJSON {
clientDataJSON: string;
attestationObject: string;
authenticatorData?: string;
transports?: AuthenticatorTransportFuture[];
publicKeyAlgorithm?: COSEAlgorithmIdentifier;
publicKey?: string;
}

// The type is returned from from native module "create" response
export interface RegistrationResponseJSON {
id: string;
rawId: string;
response: AuthenticatorAttestationResponseJSON;
authenticatorAttachment?: AuthenticatorAttachment;
clientExtensionResults: AuthenticationExtensionsClientOutputs;
type: PublicKeyCredentialType;
}
2 changes: 0 additions & 2 deletions packages/expo-passkeys/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
import { Platform } from 'react-native';

import type {
AuthenticationResponseJSON,
CredentialReturn,
PublicKeyCredentialCreationOptionsWithoutExtensions,
PublicKeyCredentialRequestOptionsWithoutExtensions,
PublicKeyCredentialWithAuthenticatorAssertionResponse,
PublicKeyCredentialWithAuthenticatorAttestationResponse,
RegistrationResponseJSON,
SerializedPublicKeyCredentialCreationOptions,
SerializedPublicKeyCredentialRequestOptions,
} from './ClerkExpoPasskeys.types';
Expand Down
5 changes: 3 additions & 2 deletions packages/expo-passkeys/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"compilerOptions": {
"allowJs": true,
"baseUrl": ".",
"declaration": true,
"declarationMap": false,
"esModuleInterop": true,
Expand All @@ -20,7 +19,9 @@
"skipLibCheck": true,
"sourceMap": false,
"strict": true,
"target": "ES2019"
"target": "ES2019",
"types": ["node"],
"rootDir": "./src"
Comment on lines +22 to +24
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Add migration coverage before merge.

This TypeScript 6 compiler-config change is not accompanied by test updates; please add/modify tests (at minimum package-level build/typecheck coverage for packages/expo-passkeys) to guard against upgrade regressions before merging.

As per coding guidelines, "If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes."

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@packages/expo-passkeys/tsconfig.json` around lines 22 - 24, The tsconfig.json
change (changing "target" to "ES2019" and other compiler settings) needs
accompanying test coverage for packages/expo-passkeys; add or update tests that
perform a package-level build/typecheck (e.g., a CI job or npm script like
"build" / "typecheck" invoked in the package's test matrix) to ensure TypeScript
6 migration does not regress, include at least one unit or integration test that
imports core modules from packages/expo-passkeys to exercise compilation, and
ensure the package.json scripts and repository CI workflow reference this
new/updated test step so the typecheck/build runs before merge.

},
"include": ["src"]
}
Loading
Loading