Fix storage container name for definitions#269
Open
joshuagl wants to merge 1 commit intoclearlydefined:mainfrom
Open
Fix storage container name for definitions#269joshuagl wants to merge 1 commit intoclearlydefined:mainfrom
joshuagl wants to merge 1 commit intoclearlydefined:mainfrom
Conversation
In 38e3197 the name of the storage container was updated to `changes-notifications`, but the name in the definitions subsection remained `production-snapshots`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 38e3197 the name of the storage container was updated to
changes-notifications, but the name in the definitions subsection remainedproduction-snapshots. Based on lightweight experimentation with thechanges-notificationsstorage container, I'm able to retrieve definitions from the root of the container and therefore assume the the README should also recommend using thechanges-notificationscontainer for retrieving definitions.