Repository navigation
Conversation
CityLearnLoadingService.load() checks for kwargs["random_episode_split"] but the argument inside CityLearnEnv.__init__() passes it as random_episode=random_episode_split. This is inconsistent to others like rolling_episode_split Signed-off-by: LB-Luca <164383820+LB-Luca@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CityLearnLoadingService.load() checks for kwargs["random_episode_split"] but the argument inside CityLearnEnv.init() passes it as random_episode=random_episode_split. This is inconsistent to others like rolling_episode_split
Description
Please provide a brief summary of the changes in this pull request.
Issue
Please provide the issue number or link to the related issue, if applicable.
Changes
Please list the changes introduced by this pull request.
Screenshots
Please provide any relevant screenshots, if applicable.
Checklist
requirements.txtfile, if applicable.Additional notes
Please provide any additional information that may be helpful for the reviewer.