Skip to content

Fix typo in random_episode parameter name - #166

Open
LB-Luca wants to merge 1 commit into
citylearn-project:masterfrom
LB-Luca:patch-1
Open

LB-Luca wants to merge 1 commit into
citylearn-project:masterfrom
LB-Luca:patch-1

Conversation

@LB-Luca

@LB-Luca LB-Luca commented Oct 21, 2026

Copy link
Copy Markdown

CityLearnLoadingService.load() checks for kwargs["random_episode_split"] but the argument inside CityLearnEnv.init() passes it as random_episode=random_episode_split. This is inconsistent to others like rolling_episode_split

Description

Please provide a brief summary of the changes in this pull request.

Issue

Please provide the issue number or link to the related issue, if applicable.

Changes

Please list the changes introduced by this pull request.

Screenshots

Please provide any relevant screenshots, if applicable.

Checklist

  • I have tested the changes locally and they work as intended.
  • I have updated the documentation, if applicable.
  • I have added new tests, if applicable.
  • I have added any required dependencies to the requirements.txt file, if applicable.
  • I have followed the project's code style and conventions.

Additional notes

Please provide any additional information that may be helpful for the reviewer.

CityLearnLoadingService.load() checks for kwargs["random_episode_split"] but the argument inside CityLearnEnv.__init__() passes it as random_episode=random_episode_split. This is inconsistent to others like rolling_episode_split

Signed-off-by: LB-Luca <164383820+LB-Luca@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 21, 2026 15:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants