Skip to content

use PG_MODULE_MAGIC_EXT to report the full version #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Arthur Nascimento (tureba) wants to merge 2 commits into
base: main
Choose a base branch
from
Open

use PG_MODULE_MAGIC_EXT to report the full version #409

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b1e2fd
use PG_MODULE_MAGIC_EXT to report the full version
tureba Oct 10, 2025
8f4c074
PG_MODULE_MAGIC_EXT: use version from CHANGELOG.md
tureba Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/pg_cron.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,11 @@
#include "utils/builtins.h"


#ifdef PG_MODULE_MAGIC_EXT
PG_MODULE_MAGIC_EXT(.name = "pg_cron", .version = "1.6.7");

@marcoslot Marco Slot (marcoslot) Dec 19, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to use a compile constant derived from the tag. We're likely to forget updating this.

@tureba Arthur Nascimento (tureba) Dec 19, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fully agree.

I see some other projects pulling their versions from macros of their own headers, or the Makefile providing the macro through CFLAGS, or other mechanisms.

But I didn't find a place where the pg_cron version was kept up to date, except in CHANGELOG.md. Not sure that parsing that is the best idea.

The file META.json looks interesting, but that also looks a bit outdated.

One could ask git-decorate for the latest tag, as you mention, but that wouldn't work when building from a .tar.gz, which some distributions may be doing.

#else
PG_MODULE_MAGIC;
#endif

#ifndef MAXINT8LEN
#define MAXINT8LEN 20
Expand Down