Fix arm64 nightly debsigner build context - #1223
Merged
Merged
Conversation
Use the debsigner directory as the Docker build context so COPY scripts includes the configured import_and_sign entrypoint. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The nightly arm64 debsigner build used the repository root as its Docker context.
dockerfiles/debsigner/DockerfilecontainsCOPY scripts /scriptsandENTRYPOINT ["/scripts/import_and_sign"], but the intended signing scripts live indockerfiles/debsigner/scripts, not the rootscriptsdirectory. The image therefore built successfully but failed when signing started because/scripts/import_and_signwas missing.This was observed in the combined develop run, including the Bookworm arm64 job. All five non-Bullseye arm64 jobs reached this failure; amd64 succeeded.
Change
Change only the
Build arm64 debsigner imagecommand to usedockerfiles/debsigneras its build context. Docker selects the same default Dockerfile and copies the correct signing scripts. Exactly one file, one line changed (+1/-1). The arm64 condition and amd64 behavior are unchanged.Validation and scope
git diff --check.Related: citusdata/citus#8612.