Report unsupported ALTER CONSTRAINT explicitly - #8808
Draft
ibrahim halatci (ihalatci) wants to merge 4 commits into
Draft
Report unsupported ALTER CONSTRAINT explicitly#8808ibrahim halatci (ihalatci) wants to merge 4 commits into
ibrahim halatci (ihalatci) wants to merge 4 commits into
Conversation
Make ALTER TABLE ... ALTER CONSTRAINT fail with a stable FEATURE_NOT_SUPPORTED error and a detail explaining that Citus does not propagate constraint property changes to shards. Also tag the related DETACH PARTITION unsupported paths with FEATURE_NOT_SUPPORTED. Refs #8758 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 61c1aeb4-1b56-4313-a35e-d65b59a557de
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8808 +/- ##
==========================================
- Coverage 88.72% 88.70% -0.02%
==========================================
Files 289 289
Lines 65073 65075 +2
Branches 8203 8202 -1
==========================================
- Hits 57739 57728 -11
- Misses 4967 4981 +14
+ Partials 2367 2366 -1 🚀 New features to boost your workflow:
|
Refs #8758 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 61c1aeb4-1b56-4313-a35e-d65b59a557de
Refs #8758 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 61c1aeb4-1b56-4313-a35e-d65b59a557de
Refs #8758 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 61c1aeb4-1b56-4313-a35e-d65b59a557de
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft partial fix for #8758.
This makes ALTER TABLE ... ALTER CONSTRAINT fail with a stable FEATURE_NOT_SUPPORTED error and detail explaining that Citus does not propagate constraint property changes to shards. It also tags the existing unsupported DETACH PARTITION CONCURRENTLY/FINALIZE paths with FEATURE_NOT_SUPPORTED.
Important limitation: I did not include MERGE PARTITIONS / SPLIT PARTITION cases because this post-merge source checkout has no corresponding AT_* enum identifiers or grammar strings. That part needs to be rechecked against the exact PostgreSQL 19 parser API before adding cases.