Fix nightly cassert issue dedup and regression.diffs glob expansion - #8791
Draft
ibrahim halatci (ihalatci) wants to merge 1 commit into
Draft
Fix nightly cassert issue dedup and regression.diffs glob expansion#8791ibrahim halatci (ihalatci) wants to merge 1 commit into
ibrahim halatci (ihalatci) wants to merge 1 commit into
Conversation
The notify job deduped on the exact sorted set of failing job names. Because the jobs that fail alongside a flaky test differ every night, one recurring flake (single_node_enterprise) opened three separate issues (#8749, #8775, #8776) whose job-name sets did not even overlap. Keep a single rolling open issue per label and append each night's failures to it instead. Also quote $diffs in the "Publish regression.diffs" step. The unquoted echo glob-expanded the * characters in the diff content against the repo root and injected a stray repository directory listing into the published diff (seen in #8768). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8791 +/- ##
==========================================
- Coverage 88.70% 88.69% -0.02%
==========================================
Files 289 289
Lines 64889 64890 +1
Branches 8181 8181
==========================================
- Hits 57559 57553 -6
- Misses 4967 4971 +4
- Partials 2363 2366 +3 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One nightly cassert flake was spawning a new issue every night. Five issues (#8749, #8768, #8769,
#8775, #8776) were opened across six days for what turned out to be five root causes surfacing in
varying combinations, all on the same commit.
Cause
The de-duplication keyed on the exact sorted set of failing job names. Those names are
PG-major-qualified, so a run failing
regresson PG16 and a run failingregresson PG17 producedisjoint key sets and are treated as unrelated. Any night-to-night variation in which PG major
happened to lose the race therefore created a fresh issue.
Fix
Keep a single rolling open issue per label. Subsequent failures append a comment to it instead of
opening a new one.
reduce((a, b) => b.number > a.number ? b : a)..filter(i => !i.pull_request)is required — the search endpoint returns pull requests alongsideissues, and without this the workflow can latch onto a PR.
Nightly cassert failures (since <date>).Also fixes an unquoted
echo -E $diffsat.github/actions/save_logs_and_results/action.yml:32,where the shell was glob-expanding the list of
regression.diffspaths.+21/−40.
Effect
Tonight's nightly appends to the existing consolidated tracker rather than opening a sixth issue.
Refs #8776