(Chat): Adding an option to register suggestions server side. - #148
Open
spoty123 wants to merge 1 commit into
Open
(Chat): Adding an option to register suggestions server side.#148spoty123 wants to merge 1 commit into
spoty123 wants to merge 1 commit into
Conversation
The main purpose of this pull request is to allow registering suggestions before clients have joined the server, and let them know about those suggestions once they join. From what I understood most "frameworks" basically save all of the server-side suggestions on the server until the client joined and only then registering those suggestions from the client itself, I believe that this will serve as a better solution (which doesn't interrupt the existing one), added a convar in case people want to remove that.
|
vouch this |
Contributor
|
This may be a month old but I guess no one else has brought this up, will this work with #101? It may be better to wait for the chat rework to be completed or better yet, make this as a suggestion to the chat rework itself! |
Author
I didn't even know about this lol, this is what I'm going to do right now. |
Closed
Author
|
Reopening this since #101 was already merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main purpose of this pull request is to allow registering suggestions before clients have joined the server, and let them know about those suggestions once they join.
From what I understood most "frameworks" basically save all of the server-side suggestions on the server until the client joined and only then registering those suggestions from the client itself, I believe that this will serve as a better solution (which doesn't interrupt the existing one), added a convar in case people want to remove that.