Skip to content

Add value check to orgName in VSDashboardGate#1513

Open
ameliav wants to merge 1 commit into
developfrom
bug-fix-org-name-4000
Open

Add value check to orgName in VSDashboardGate#1513
ameliav wants to merge 1 commit into
developfrom
bug-fix-org-name-4000

Conversation

@ameliav

@ameliav ameliav commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

🗣 Description

Fix the edge case bug for undefined values for "Add an alert banner for Users a part of DHS Region 1-10 (CRASM-4000)"

💭 Motivation and context

Ensure alert banner will not error out for undefined/pre-loaded orgs. Continuation of #1509

🧪 Testing

See if an undefined or null org provides back an error

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.
  • Bump major, minor, patch, pre-release, and/or build versions as appropriate via the bump_version script if this repository is versioned and the changes in this PR warrant a version bump.
  • Create a pre-release (necessary if and only if the pre-release version was bumped).

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release (necessary if and only if the version was bumped).

@ameliav ameliav self-assigned this Jun 26, 2026
@ameliav ameliav marked this pull request as ready for review June 26, 2026 16:00
@ameliav ameliav requested a review from jayjaybunce June 26, 2026 16:00
@ameliav ameliav changed the title Add undefined null check to orgName in VSDashboardGate Add null and undefined value check to orgName in VSDashboardGate Jun 26, 2026
@ameliav ameliav changed the title Add null and undefined value check to orgName in VSDashboardGate Add value check to orgName in VSDashboardGate Jun 26, 2026

@jayjaybunce jayjaybunce left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally and bug has been squashed.

@hawkishpolicy hawkishpolicy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally.

works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants